Delete Calico IPPools when Submariner uninstalled #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Calico IPPools created by Submariner should be deleted when Submariner is uninstalled. This PR updates Calico IPPools handler Uninstall function to delete all IPPools regardless of isGateway field status. Fixes: submariner-io#2764 Signed-off-by: Yossi Boaron <[email protected]>
yboaron
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2766/yboaron/ippool_uninstall |
sridhargaddam
approved these changes
Oct 26, 2023
skitt
approved these changes
Oct 27, 2023
Signed-off-by: Stephen Kitt <[email protected]>
|
This needs to be backported, doesn’t it? |
skitt
added
the
backport
|
@skitt @sridhargaddam |
Signed-off-by: Yossi Boaron <[email protected]>
|
🤖 Closed branches: [z_pr2766/yboaron/ippool_uninstall] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Calico IPPools created by Submariner should be deleted when Submariner is uninstalled.
This PR updates Calico IPPools handler Uninstall function to delete all IPPools regardless of isGateway field status.
Fixes: #2764