Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico IPPools created by Submariner not deleted when Submariner uninstalled #2764

Closed
yboaron opened this issue Oct 24, 2023 · 0 comments · Fixed by #2766
Closed

Calico IPPools created by Submariner not deleted when Submariner uninstalled #2764

yboaron opened this issue Oct 24, 2023 · 0 comments · Fixed by #2766
Assignees
@yboaron
Labels
bug Something isn't working priority:low

Comments

@yboaron
Copy link
Contributor

yboaron commented Oct 24, 2023

What happened:

Calico IPPools created by Submariner (to enable cross-cluster traffic ) are not deleted when Submariner is uninstalled.

What you expected to happen:

Submariner should delete these IPPools.

How to reproduce it (as minimally and precisely as possible):

  1. Verify that Calico API-server runs within cluster
  2. Deploy Submariner (version > 0.16)
  3. Check for Calico IPPools created by Submariner
  4. Uninstall Submariner

Anything else we need to know?:

Environment:

  • Diagnose information (use subctl diagnose all):
  • Gather information (use subctl gather):
  • Cloud provider or hardware configuration:
  • Install tools:
  • Others:
@yboaron yboaron added the bug Something isn't working label Oct 24, 2023
@yboaron yboaron self-assigned this Oct 24, 2023
yboaron added a commit to yboaron/submariner that referenced this issue Oct 25, 2023
@yboaron
Delete Calico IPPools when Submariner uninstalled
db2e334 
All Calico IPPools created by Submariner should be deleted
when Submariner is uninstalled.

This PR updates Calico IPPools handler Uninstall function to delete
all IPPools regardless of isGateway field status.

Fixes: submariner-io#2764

Signed-off-by: Yossi Boaron <[email protected]>
@yboaron yboaron mentioned this issue Oct 25, 2023
Merged
@maayanf24 maayanf24 moved this from Todo to In Review in Submariner 0.17 Oct 26, 2023
skitt pushed a commit that referenced this issue Oct 29, 2023
@yboaron @skitt
Delete Calico IPPools when Submariner uninstalled
4e63237 
All Calico IPPools created by Submariner should be deleted
when Submariner is uninstalled.

This PR updates Calico IPPools handler Uninstall function to delete
all IPPools regardless of isGateway field status.

Fixes: #2764

Signed-off-by: Yossi Boaron <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Submariner 0.17 Oct 29, 2023
yboaron added a commit to yboaron/submariner that referenced this issue Oct 29, 2023
@yboaron
Delete Calico IPPools when Submariner uninstalled
8c0afaa 
All Calico IPPools created by Submariner should be deleted
when Submariner is uninstalled.

This PR updates Calico IPPools handler Uninstall function to delete
all IPPools regardless of isGateway field status.

Fixes: submariner-io#2764

Signed-off-by: Yossi Boaron <[email protected]>
skitt pushed a commit that referenced this issue Oct 30, 2023
@yboaron @skitt
Delete Calico IPPools when Submariner uninstalled
c8099a8 
All Calico IPPools created by Submariner should be deleted
when Submariner is uninstalled.

This PR updates Calico IPPools handler Uninstall function to delete
all IPPools regardless of isGateway field status.

Fixes: #2764

Signed-off-by: Yossi Boaron <[email protected]>
novad03 pushed a commit to novad03/k8s-submariner that referenced this issue Nov 25, 2023
@yboaron @skitt
Delete Calico IPPools when Submariner uninstalled
39c8929 
All Calico IPPools created by Submariner should be deleted
when Submariner is uninstalled.

This PR updates Calico IPPools handler Uninstall function to delete
all IPPools regardless of isGateway field status.

Fixes: submariner-io/submariner#2764

Signed-off-by: Yossi Boaron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yboaron yboaron

Labels
bug Something isn't working priority:low
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete Calico IPPools when Submariner uninstalled yboaron/submariner
1 participant
@yboaron