Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow broker access to broker-client role #2547

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Mar 24, 2023

This allows other clusters to get/list broker CR using Broker restconfig.

Epic: submariner-io/enhancements#143

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2547/Jaanki/get_broker
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@github-advanced-security
Copy link

You have successfully added a new Grype configuration .github/workflows/linting.yml:vulnerability-scan. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Jaanki Jaanki marked this pull request as draft March 24, 2023 11:51
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/linting.yml:variant-analysis. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Jaanki Jaanki marked this pull request as ready for review March 24, 2023 11:57
Jaanki added a commit to Jaanki/subctl that referenced this pull request Mar 24, 2023
instead of specifying both Broker and Submariner clusters.

Depnds on:
submariner-io/submariner-operator#2547

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/subctl that referenced this pull request Mar 24, 2023
instead of specifying both Broker and Submariner clusters.

Depends on:
submariner-io/submariner-operator#2547

Epic: submariner-io/enhancements#143

Signed-off-by: Janki Chhatbar <[email protected]>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Mar 27, 2023
- apiGroups:
- submariner.io
resources:
- brokers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked about on a call, there isn't any sensitive information in this CR.

@sridhargaddam sridhargaddam enabled auto-merge (squash) March 27, 2023 18:29
This allows other clusters to get/list broker CR using Broker
restconfig.

Epic: submariner-io/enhancements#143

Signed-off-by: Janki Chhatbar <[email protected]>
@Jaanki Jaanki self-assigned this Mar 28, 2023
@sridhargaddam sridhargaddam merged commit b2d0c31 into submariner-io:devel Mar 28, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2547/Jaanki/get_broker]

Jaanki added a commit to Jaanki/subctl that referenced this pull request Mar 28, 2023
instead of specifying both Broker and Submariner clusters.
System tests are also accordingly adjusted.

Depends on:
submariner-io/submariner-operator#2547

Epic: submariner-io/enhancements#143

Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki added a commit to Jaanki/subctl that referenced this pull request Mar 29, 2023
instead of specifying both Broker and Submariner clusters.
System tests are also accordingly adjusted.

Depends on:
submariner-io/submariner-operator#2547

Epic: submariner-io/enhancements#143

Signed-off-by: Janki Chhatbar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants