Use only subm cluster to recover broker-info.subm #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaanki
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr621/Jaanki/only_subm_recover |
|
You have successfully added a new Grype configuration |
Jaanki
force-pushed
the
only_subm_recover
branch
from
f9a0765
to
27d21a2
Compare
Jaanki
force-pushed
the
only_subm_recover
branch
3 times, most recently
from
7f44bbe
to
85fc13d
Compare
Jaanki
force-pushed
the
only_subm_recover
branch
from
85fc13d
to
aa49c2f
Compare
Jaanki
added a commit
to Jaanki/submariner-operator
that referenced
this pull request
Mar 29, 2023
subctl uses its own Broker RBAC permissions. New permissions are recently added in subctl. Sync those permissions in operator repo as well because these are used by ACM or other third parties. Depends on submariner-io/subctl#621 Signed-off-by: Janki Chhatbar <[email protected]>
tpantelis
requested changes
Mar 29, 2023
Jaanki
force-pushed
the
only_subm_recover
branch
from
adf5c70
to
c694175
Compare
Jaanki
force-pushed
the
only_subm_recover
branch
from
c694175
to
b33d771
Compare
tpantelis
approved these changes
Mar 29, 2023
...instead of specifying both Broker and Submariner clusters. Add required RBAC permissions for the client cluster to access the Broker. System tests are also accordingly adjusted. Epic: submariner-io/enhancements#143 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
force-pushed
the
only_subm_recover
branch
from
b33d771
to
77da496
Compare
19 tasks
maayanf24
approved these changes
Mar 30, 2023
|
🤖 Closed branches: [z_pr621/Jaanki/only_subm_recover] |
skitt
pushed a commit
to submariner-io/submariner-operator
that referenced
this pull request
Mar 30, 2023
subctl uses its own Broker RBAC permissions. New permissions are recently added in subctl. Sync those permissions in operator repo as well because these are used by ACM or other third parties. Depends on submariner-io/subctl#621 Signed-off-by: Janki Chhatbar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: submariner-io/enhancements#143
Signed-off-by: Janki Chhatbar [email protected]