Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unused parameters #1065

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Ignore unused parameters #1065

merged 2 commits into from
Feb 27, 2024

Conversation

skitt
Copy link
Member

@skitt skitt commented Feb 13, 2024

No description provided.

@skitt
Ignore unused parameters
db09f05 
Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1065/skitt/ignore-unused-params
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt mentioned this pull request Feb 13, 2024
Merged
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Feb 26, 2024
@tpantelis tpantelis enabled auto-merge (rebase) February 27, 2024 17:48
@tpantelis tpantelis merged commit 15a9ee7 into submariner-io:devel Feb 27, 2024
30 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1065/skitt/ignore-unused-params]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @dfarrell07 @tpantelis