Bump golangci-lint to 1.56.2 #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1550/skitt/golangci-lint-1.56.0 |
vthapar
approved these changes
Feb 12, 2024
skitt
force-pushed
the
golangci-lint-1.56.0
branch
from
976a347 to
f181d81
Compare
skitt
force-pushed
the
golangci-lint-1.56.0
branch
from
f181d81 to
be17e1f
Compare
vthapar
approved these changes
Feb 15, 2024
This adds support for Go 1.22. Required fixes: * compare strings with "" instead of checking their length * ignore an unused function parameter * various wsl cuddling fixes Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
golangci-lint-1.56.0
branch
from
75453df to
ba97343
Compare
tpantelis
approved these changes
Feb 28, 2024
|
🤖 Closed branches: [z_pr1550/skitt/golangci-lint-1.56.0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Go 1.22.
Required fixes:
Depends on submariner-io/admiral#849
Depends on submariner-io/admiral#854
Depends on submariner-io/cloud-prepare#894
Depends on submariner-io/cloud-prepare#895
Depends on submariner-io/lighthouse#1504
Depends on submariner-io/lighthouse#1506
Depends on submariner-io/subctl#1064
Depends on submariner-io/subctl#1065
Depends on submariner-io/submariner#2910
Depends on submariner-io/submariner#2912
Depends on submariner-io/submariner-operator#2966
Depends on submariner-io/submariner-operator#2967