Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shflags 1.0.3 to 1.2.3 #743

Closed
wants to merge 3 commits into from

Conversation

dfarrell07
Copy link
Member

Also update the path from which it's installed, as it has changed
between releases.

Signed-off-by: Daniel Farrell [email protected]

Also update the path from which it's installed, as it has changed
between releases.

Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 added the e2e-projects Run E2E tests in each consuming project label Feb 28, 2022
@dfarrell07 dfarrell07 self-assigned this Feb 28, 2022
@submariner-bot
Copy link

🤖 Created branch: z_pr743/dfarrell07/shflags_123_again

@dfarrell07
Copy link
Member Author

This breaks things and needs special attention, see #741.

@stale
Copy link

stale bot commented Mar 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 15, 2022
@dfarrell07 dfarrell07 added help wanted Extra attention is needed next-version-candidate and removed wontfix This will not be worked on labels Mar 15, 2022
@stale
Copy link

stale bot commented Apr 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 18, 2022
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Apr 19, 2022
@stale
Copy link

stale bot commented May 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 4, 2022
@dfarrell07 dfarrell07 added confirmed For issues and PRs which we definitely want (disables the stale bot) and removed wontfix This will not be worked on labels May 5, 2022
@nyechiel
Copy link
Member

nyechiel commented Jul 4, 2022

@dfarrell07 @skitt is this still relevant?

@skitt
Copy link
Member

skitt commented Jul 5, 2022

Redone with an additional required fix in #854.

@skitt skitt closed this Jul 5, 2022
@submariner-bot
Copy link

🤖 Closed branches: [z_pr743/dfarrell07/shflags_123_again]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed For issues and PRs which we definitely want (disables the stale bot) e2e-projects Run E2E tests in each consuming project help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants