Revert "Update shflags 1.0.3 to 1.2.3" #741
Conversation
dfarrell07
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr741/dfarrell07/revert_shflags_123 |
This reverts commit 264c1e7. Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07
force-pushed
the
revert_shflags_123
branch
from
a220f66 to
3d1f205
Compare
|
I'm testing if this is needed. Some jobs failed on the last run of #732, but because they were not required it auto-merged. |
|
I think this is needed, right @skitt? Most of the E2E Consuming jobs failed on the last run of the original: https://github.com/submariner-io/shipyard/runs/5362334989?check_suite_focus=true And are passing with the revert: https://github.com/submariner-io/shipyard/runs/5362593481?check_suite_focus=true |
|
I'm running the E2E Consuming on current devel again here: dfarrell07#34 |
Yeah these are failing in the same way, so I do think we should merge this quickly. |
|
Sorry for the auto-merge of the original, all! I wanted to show "let's merge this next, it has a huge set of jobs to re-run". I was watching the jobs, but the required ones finished quickly and it merged before any started failing. |
|
🤖 Closed branches: [z_pr741/dfarrell07/revert_shflags_123] |
This reverts commit 264c1e7.