Fix "per-surface" outputs #1341
Conversation
|
This pull request fixes 2 alerts when merging fa7f165 into f47e22b - view on LGTM.com fixed alerts:
|
| void CFlowOutput::WriteForcesBreakdown(CConfig *config, CGeometry *geometry, CSolver **solver_container){ | ||
| void CFlowOutput::WriteForcesBreakdown(const CConfig* config, const CSolver* flow_solver) const { |
There was a problem hiding this comment.
Most of that last commit was trying to make this function less ugly.
|
This pull request fixes 2 alerts when merging c43559e into f47e22b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 9577cba into f47e22b - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Well thanks for this fix(es) and massive cleanup 💐 Someone at some point will surely appreciate that tedious work!
Moreover, the "per surface" implementation is only considering the first marker name and value for printing.
However, there is one value added per "marker analyse".
Can you point me to where that went wrong real quick. I was not able to spot that while going over 😬
| const bool si_units; | ||
| const bool us_units; |
| } | ||
| } | ||
| (*convergenceTable) << out.str(); |
There was a problem hiding this comment.
We were re-using this string stream and that created the lumped values without separator.
| case ScreenOutputFormat::FIXED: | ||
| PrintingToolbox::PrintScreenFixed(out, field.value, fieldWidth); | ||
| break; | ||
| case ScreenOutputFormat::SCIENTIFIC: |
There was a problem hiding this comment.
I should have made this block a lambda or something for re-use, one day...
Fixes #1336