Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Per surface" outputs do not work #1336

Closed
pcarruscag opened this issue Jul 29, 2021 · 1 comment · Fixed by #1341
Closed

"Per surface" outputs do not work #1336

pcarruscag opened this issue Jul 29, 2021 · 1 comment · Fixed by #1341
Labels

Comments

@pcarruscag
Copy link
Member

The "per surface" problem starts in COutput::CheckHistoryOutput where the table header is not given the right number of columns. The function does not add the "per surface names" because we are using the same identifier for normal outputs and "per surface" outputs.
Moreover, the "per surface" implementation is only considering the first marker name and value for printing.
However, there is one value added per "marker analyse".
Let's fix this in a different PR.

Originally posted by @pcarruscag in #1226 (comment)

@pcarruscag pcarruscag added the bug label Jul 29, 2021
@TobiKattmann
Copy link
Contributor

I just noticed that this also means that e.g. SURFACE_STATIC PRESSURE in screen outputs cannot be used for regression tests as the python script needs a delimiter in between values which is not the case with that doubled output.

@pcarruscag pcarruscag linked a pull request Jul 31, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants