Fixed rare filtering issue for old studentquiz instances

studentquiz · Feb 13, 2019 · d89ce46 · d89ce46
1 parent f62e9ec
commit d89ce46
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/classes/condition/studentquiz_condition.php b/classes/condition/studentquiz_condition.php
@@ -139,11 +139,13 @@ protected function init() {
     }
 
     private function get_special_sql($sqldata, $name) {
-        if (substr($sqldata, 0, 12) === 'mydifficulty') {
-            return str_replace('mydifficulty', 'ROUND(1 - (sp.correctattempts / sp.attempts),2)', $sqldata);
-        }
-        if ($name == "onlynew") {
-            return str_replace('myattempts', 'sp.attempts', $sqldata);
+        if ($this->studentquiz->aggregated) {
+            if (substr($sqldata, 0, 12) === 'mydifficulty') {
+                return str_replace('mydifficulty', 'ROUND(1 - (sp.correctattempts / sp.attempts),2)', $sqldata);
+            }
+            if ($name == "onlynew") {
+                return str_replace('myattempts', 'sp.attempts', $sqldata);
+            }
         }
         return $sqldata;
     }