Fixed multiple refactoring issues

Question Bank Import Category missing Wrong SQL Escape
studentquiz · Feb 13, 2019 · f62e9ec · f62e9ec
1 parent 59587ee
commit f62e9ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/classes/question/bank/difficulty_level_column.php b/classes/question/bank/difficulty_level_column.php
@@ -112,9 +112,9 @@ public function get_extra_joins() {
                                             GROUP BY qa.questionid
                                             ) dl ON dl.questionid = q.id",
                     'mydiffs' => "LEFT JOIN (
-                                              SELECT ROUND(1-avg(case state when \'gradedright\' then 1 else 0 end),2)
+                                              SELECT ROUND(1-avg(case state when 'gradedright' then 1 else 0 end),2)
                                                          AS mydifficulty,
-                                                     sum(case state when \'gradedright\' then 1 else 0 end) AS mycorrectattempts,
+                                                     sum(case state when 'gradedright' then 1 else 0 end) AS mycorrectattempts,
                                                      questionid
                                                 FROM {studentquiz_attempt} sqa
                                                 JOIN {question_usages} qu ON qu.id = sqa.questionusageid

diff --git a/viewlib.php b/viewlib.php
@@ -129,6 +129,8 @@ private function load_questionbank() {
         // TODO: We should fix these with the updates and restore functions (analog fix question category etc.)
         mod_studentquiz_ensure_question_capabilities($this->context);
 
+        $_POST['cat'] = $this->get_category_id() . ',' . $this->get_context_id();
+
         // Get edit question link setup
         list($thispageurl, $contexts, $cmid, $cm, $module, $pagevars)
             = question_edit_setup('questions', '/mod/studentquiz/view.php', true);