feat(mocha 6): support all config formats #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for all mocha's configuration formats:
* Arguments specified on command-line
* Configuration file (.mocharc.js, .mocharc.yml, etc.)
1. .mocharc.js
2. .mocharc.yaml
3. .mocharc.yml
4. .mocharc.jsonc
5. .mocharc.json
* mocha property of package.json
* mocha.opts
This works by using mocha 6's [`loadOptions`](https://mochajs.org/api/module-lib_cli_options.html#.loadOptions) function if it is available.
If not (mocha < 6), use old parsing logic.
See https://mochajs.org/#configuring-mocha-nodejs
ghost
assigned 
simondel
approved these changes
Apr 19, 2019
| const mochaOptions = Object.assign({}, config[mochaOptionsKey]) as MochaRunnerOptions; | ||
| return Object.assign(this.loadMochaOptsFile(mochaOptions.opts), mochaOptions); | ||
| public load(strykerOptions: StrykerOptions): MochaOptions { | ||
| const mochaOptions = Object.assign({}, strykerOptions[mochaOptionsKey]) as MochaOptions; |
There was a problem hiding this comment.
Let's use a spread operator for this { ...strykerOptions[mochaOptionsKey] }
| return Object.assign(this.loadMochaOptsFile(mochaOptions.opts), mochaOptions); | ||
| public load(strykerOptions: StrykerOptions): MochaOptions { | ||
| const mochaOptions = Object.assign({}, strykerOptions[mochaOptionsKey]) as MochaOptions; | ||
| return Object.assign(this.loadMochaOptions(mochaOptions), mochaOptions); |
There was a problem hiding this comment.
Let's use a spread operator for this { ...this.loadMochaOptions(mochaOptions), ...mochaOptions }
Different PR sounds good. That way, we can already release this without a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for all mocha's configuration formats:
This works by using mocha 6's
loadOptionsfunction if it is available.If not (mocha < 6), use old parsing logic.
See https://mochajs.org/#configuring-mocha-nodejs
Closes #1414