Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Failures #183

Closed
1 task
nabdelgadir opened this issue Jul 16, 2019 · 3 comments
Closed
1 task

Fix CI Failures #183

nabdelgadir opened this issue Jul 16, 2019 · 3 comments

Comments

@nabdelgadir
Copy link
Contributor

nabdelgadir commented Jul 16, 2019

Description/Steps to reproduce

Currently there are five CI failures:

   1) juggler-v3
        datatypes
          "before all" hook for "should resolve top-level "type" property correctly":
      Error: ORA-00972: identifier is too long
   
 
   2) juggler-v3
        basic-querying
          "before all" hook in "basic-querying":
      Error: ORA-00955: name is already used by an existing object
   
 
   3) juggler-v3
        regexp operator
          "before all" hook: seed for "should return an error for invalid data types":
      Error: ORA-01400: cannot insert NULL into ("TEST"."USER"."ID")
   
 
   4) juggler-v4
        datatypes
          "before all" hook for "should resolve top-level "type" property correctly":
      Error: ORA-00972: identifier is too long
   
 
   5) juggler-v4
        basic-querying
          "before all" hook in "basic-querying":
      Error: ORA-00972: identifier is too long
   

The ORA-00972: identifier is too long error happens when an identifier is over 30 characters.

The failures are from the before hooks of the datatype.test.js and basic-querying.test.js files (not sure where regexp operator is from).

Acceptance Criteria

  • Fix the errors so CI passes
@cjbj
Copy link

cjbj commented Jul 16, 2019

As of Oracle DB 12.2 identifiers can be 128 characters. Do you need to test older DBs? Oracle 18 & 19 are also available - and there is a free Oracle XE 18 available.

@dhmlau dhmlau added the 2019Q3 label Jul 18, 2019
@agnes512
Copy link
Contributor

Maybe check db versions and update Docker images.
and check sql statement in here and use debug string.

@hacksparrow
Copy link
Contributor

CI made to pass via PR: #189.
Follow up issue: #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants