Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #189

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Fix CI #189

merged 1 commit into from
Sep 18, 2019

Conversation

hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented Sep 18, 2019 •
edited
Loading

Addresses CI failure reported in #183.

var had to be changed to const to fix linting error.

@hacksparrow hacksparrow changed the title temp Fix CI Sep 18, 2019
@hacksparrow hacksparrow mentioned this pull request Sep 18, 2019
Closed
2 tasks
jannyHou
jannyHou approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@hacksparrow hacksparrow merged commit 54322f3 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the temp branch September 18, 2019 14:00
@hacksparrow hacksparrow mentioned this pull request Sep 18, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@dhmlau dhmlau dhmlau approved these changes

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike Awaiting requested review from b-admike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hacksparrow @jannyHou @dhmlau @nabdelgadir