Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce identifier length [4.x] #1775

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented Sep 3, 2019

Existing identifier length exceeds Oracle DB's limit.

Related issues

loopbackio/loopback-connector-oracle#183

Existing identifier length exceeds Oracle DB's limit
@hacksparrow hacksparrow force-pushed the reduce-identifier-length-4.x branch from 1060051 to 6f491dc Compare September 3, 2019 15:16
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way how to shorten the names in the Oracle connector automatically 🤷‍♂

BTW the Oracle downstream CI build has failed, is that expected?

@hacksparrow
Copy link
Contributor Author

BTW the Oracle downstream CI build has failed, is that expected?

Yes. There are other test failures, I will be going through them and fixing them.

@hacksparrow hacksparrow changed the title chore: reduce identifier length chore: reduce identifier length [4.x] Sep 4, 2019
@hacksparrow hacksparrow merged commit 6f491dc into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the reduce-identifier-length-4.x branch September 4, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants