Add Quantity and UnitAmount to InvoiceItemParams
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
requested changes
Jul 5, 2018
| Subscription *string `form:"subscription"` | ||
| UnitAmount *int64 `form:"unit_amount"` | ||
| } |
There was a problem hiding this comment.
I think you want to add them to the InvoiceItem struct too
There was a problem hiding this comment.
Yes ... that would make sense. I just pushed that change (only UnitAmount was missing).
Both these parameters were missing from the params struct, but are documented in the API [1]. This patch adds them in. Fixes #619. [1] https://stripe.com/docs/api/php#create_invoiceitem
brandur-stripe
force-pushed
the
brandur-missing-invoice-item-params
branch
from
5815f81 to
455343d
Compare
remi-stripe
approved these changes
Jul 5, 2018
|
Thanks Remi. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* added KMS * made rubocop happy * fixed typing * rubocop fix * hidden rbi * ran sorbet autocorrect * more sorbet fixes * last sorbet fixes * fixed migration typo * Cleanup migration file * Generate kms fields * sorbet fixes * Remove pry * Removing weird reline sorbet stuff * Fix migration syntax * Fix migrations on ci * Try exponential backoff with bash * changed env var * Rename migration folder * More backoff, some ci config cleanup * Fix rubocop * Fix kms test * bundle * fixed two tests * fixed nonsensical test * rubocop Co-authored-by: Mike Bianco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both these parameters were missing from the params struct, but are
documented in the API [1]. This patch adds them in.
Fixes #619.
[1] https://stripe.com/docs/api/php#create_invoiceitem
r? @remi-stripe
cc @stripe/api-libraries