Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing fields in InvoiceItemParams #619

Closed
jimbeveridge opened this issue Jul 5, 2018 · 2 comments
Closed

Missing fields in InvoiceItemParams #619

jimbeveridge opened this issue Jul 5, 2018 · 2 comments
Assignees
@remi-stripe

Comments

@jimbeveridge
Copy link

The fields unit_amount and quantity are both missing from InvoiceItemParams. These are definitely supported by the server because they are used by the admin UI to create invoice items (as shown by examining the POST'd JSON).
@remi-stripe remi-stripe self-assigned this Jul 5, 2018
brandur-stripe pushed a commit that referenced this issue Jul 5, 2018
@brandur
Add Quantity and UnitAmount to InvoiceItemParams
5815f81 
Both these parameters were missing from the params struct, but are
documented in the API [1]. This patch adds them in.

Fixes #619.

[1] https://stripe.com/docs/api/php#create_invoiceitem
@brandur brandur mentioned this issue Jul 5, 2018
Merged
@brandur-stripe
Copy link
Contributor

Thanks for the report! We have a fix coming through in #620.

brandur-stripe pushed a commit that referenced this issue Jul 5, 2018
@brandur
Add Quantity and UnitAmount to InvoiceItemParams
455343d 
Both these parameters were missing from the params struct, but are
documented in the API [1]. This patch adds them in.

Fixes #619.

[1] https://stripe.com/docs/api/php#create_invoiceitem
@brandur-stripe
Copy link
Contributor

Released as 35.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remi-stripe remi-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimbeveridge @remi-stripe @brandur-stripe