-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plans and products using 2017-12-01 API version format #496
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,8 @@ type ProductParams struct { | |
Name string `form:"name"` | ||
PackageDimensions *PackageDimensions `form:"package_dimensions"` | ||
Shippable *bool `form:"shippable"` | ||
Statement string `form:"statement_descriptor"` | ||
Type string `form:"type"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
URL string `form:"url"` | ||
} | ||
|
||
|
@@ -47,8 +49,10 @@ type Product struct { | |
PackageDimensions *PackageDimensions `json:"package_dimensions"` | ||
Shippable bool `json:"shippable"` | ||
Skus *SKUList `json:"skus"` | ||
Statement string `json:"statement_descriptor"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
URL string `json:"url"` | ||
Updated int64 `json:"updated"` | ||
Type string `json:"type"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
} | ||
|
||
// ProductList is a list of products as retrieved from a list endpoint. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you name it
StatementDescriptor
? I'm working on renaming all properties in #459 to ensure they match, as best as possible, the API name