Create plans and products using 2017-12-01 API version format #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to remain a work-in-progress until we've released a new API version and can push updates to |
2 tasks
|
Thanks for pushing this along @jhoon-stripe! Let us know how those server-side changes come along. Happy to review this in more detail when it's ready to come in. |
remi-stripe
reviewed
Dec 6, 2017
product.go
Outdated
| @@ -27,6 +27,8 @@ type ProductParams struct { | |||
| Name string `form:"name"` | |||
| PackageDimensions *PackageDimensions `form:"package_dimensions"` | |||
| Shippable *bool `form:"shippable"` | |||
| Statement string `form:"statement_descriptor"` | |||
There was a problem hiding this comment.
can you name it StatementDescriptor? I'm working on renaming all properties in #459 to ensure they match, as best as possible, the API name
product.go
Outdated
| @@ -27,6 +27,8 @@ type ProductParams struct { | |||
| Name string `form:"name"` | |||
| PackageDimensions *PackageDimensions `form:"package_dimensions"` | |||
| Shippable *bool `form:"shippable"` | |||
| Statement string `form:"statement_descriptor"` | |||
| Type string `form:"type"` | |||
There was a problem hiding this comment.
Type should likely be using const instead of just a string. Example: on Account's Type here
product.go
Outdated
| @@ -47,8 +49,10 @@ type Product struct { | |||
| PackageDimensions *PackageDimensions `json:"package_dimensions"` | |||
| Shippable bool `json:"shippable"` | |||
| Skus *SKUList `json:"skus"` | |||
| Statement string `json:"statement_descriptor"` | |||
product.go
Outdated
| URL string `json:"url"` | ||
| Updated int64 `json:"updated"` | ||
| Type string `json:"type"` |
… => StatementDescriptor
rachelr593
approved these changes
Jan 23, 2018
|
Should close this in favor of: #518 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements upcoming changes to the way in which plan objects are created in the Stripe API. Specifically, it:
Testing
Tested against
stripe-mockusing as-yet unreleased spec- and fixture updates.r? @brandur-stripe @tmaxwell-stripe
cc @stripe/api-libraries