-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bank on eps/p24 #1236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Richard. Left one comment, but LGTM.
@@ -172,10 +172,12 @@ type PaymentIntentPaymentMethodDataParams struct { | |||
AUBECSDebit *PaymentMethodAUBECSDebitParams `form:"au_becs_debit"` | |||
BillingDetails *BillingDetailsParams `form:"billing_details"` | |||
Card *PaymentMethodCardParams `form:"card"` | |||
EPS *PaymentMethodEPSParams `form:"eps"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arg, it looks like this should be "EPS", but it's called Eps
on Charge
. We should probably keep it the same between the two just for the sake of consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Eps on Charge, but unfortunately it is also EPS in paymentmethod.go and account.go and I think it is probably better to be consistent with that?
ptal @brandur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Eps on Charge, but unfortunately it is also EPS in paymentmethod.go and account.go and I think it is probably better to be consistent with that?
Ah, fair. Yep, let's go with EPS
then.
ptal @richardm-stripe |
…match Order / Order Item coupon count (#1236)
r? @brandur-stripe
cc @stripe/api-library-reviewers
Add support for
Bank
for eps and p24 on Charge and PaymentMethod.Add support for
TOSShownAndAccepted
onPaymentMethodP24Params