Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bank on eps/p24 #1236

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Dec 11, 2020

r? @brandur-stripe
cc @stripe/api-library-reviewers

Add support for Bank for eps and p24 on Charge and PaymentMethod.
Add support for TOSShownAndAccepted on PaymentMethodP24Params

paymentmethod.go Outdated Show resolved Hide resolved
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Richard. Left one comment, but LGTM.

@@ -172,10 +172,12 @@ type PaymentIntentPaymentMethodDataParams struct {
AUBECSDebit *PaymentMethodAUBECSDebitParams `form:"au_becs_debit"`
BillingDetails *BillingDetailsParams `form:"billing_details"`
Card *PaymentMethodCardParams `form:"card"`
EPS *PaymentMethodEPSParams `form:"eps"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg, it looks like this should be "EPS", but it's called Eps on Charge. We should probably keep it the same between the two just for the sake of consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Eps on Charge, but unfortunately it is also EPS in paymentmethod.go and account.go and I think it is probably better to be consistent with that?
ptal @brandur

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Eps on Charge, but unfortunately it is also EPS in paymentmethod.go and account.go and I think it is probably better to be consistent with that?

Ah, fair. Yep, let's go with EPS then.

@brandur-stripe
Copy link
Contributor

ptal @richardm-stripe

@richardm-stripe richardm-stripe merged commit 5f8a12f into master Jan 11, 2021
@richardm-stripe richardm-stripe deleted the richardm-add-support-for-eps-p24 branch January 11, 2021 17:48
nadaismail-stripe added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants