[CF RUN Issue] Raise error if quote / quote line associations do not …

…match Order / Order Item coupon count (#1236)
stripe · Nov 9, 2023 · 8472d9a · 8472d9a
1 parent 3b37370
commit 8472d9a
Show file tree

Hide file tree

Showing 13 changed files with 23,260 additions and 12,203 deletions.
diff --git a/lib/stripe-force/translate/coupon.rb b/lib/stripe-force/translate/coupon.rb
@@ -113,12 +113,18 @@ def get_salesforce_stripe_coupons_associated_to_sf_object(sf_client:, sf_object:
         lookup_field = 'Order_Item__c'
       else
         # this should never happen since coupons can only be tied to an order or order item
-        raise Integrations::Errors::ImpossibleState.new("unsupported sf object type for coupons: #{source_sf_record_type}")
+        raise Integrations::Errors::ImpossibleState.new("Unsupported sf object type for coupons: #{source_sf_record_type}")
       end
 
       # check if there are any coupon associations to this order or order item
       coupon_data = backoff { sf_client.query("Select #{SF_ID} from #{prefixed_stripe_field(ORDER_SF_STRIPE_COUPON)} where #{prefixed_stripe_field(lookup_field)} = '#{sf_object.Id}'") }
 
+      associations = get_quote_associations_for_sf_object(sf_client: sf_client, sf_object: sf_object)
+      if associations.size != coupon_data.size
+        log.info 'found a different number of coupons associations for sf object', salesforce_object: sf_object, sf_association_count: associations.size, sf_order_coupon_count: coupon_data.size
+        raise Integrations::Errors::ImpossibleInternalError.new("The sf object has a different number of quote / quote line associations than Order coupons.")
+      end
+
       # there could be multiple coupons associated with a single order or order line
       coupons = coupon_data.map do |data|
         backoff { sf_client.find(prefixed_stripe_field(ORDER_SF_STRIPE_COUPON), data.Id) }
@@ -127,4 +133,25 @@ def get_salesforce_stripe_coupons_associated_to_sf_object(sf_client:, sf_object:
       coupons
     end
   end
+
+  def get_quote_associations_for_sf_object(sf_client:, sf_object:)
+    source_sf_record_type = sf_object.sobject_type
+    if source_sf_record_type == SF_ORDER
+      lookup_field = 'Quote__c'
+      lookup_object = QUOTE_SF_STRIPE_COUPON_ASSOCIATION
+      lookup_field_id = sf_object[CPQ_QUOTE]
+    elsif source_sf_record_type == SF_ORDER_ITEM
+      lookup_field = 'Quote_Line__c'
+      lookup_object = QUOTE_LINE_SF_STRIPE_COUPON_ASSOCIATION
+      lookup_field_id = sf_object[CPQ_QUOTE_LINE]
+    else
+      # this should never happen since coupons can only be tied to an order or order item
+      raise Integrations::Errors::ImpossibleState.new("Unsupported sf object type for coupons: #{source_sf_record_type}")
+    end
+
+    # check if there are any coupon associations to this order or order item
+    qla_data = backoff { sf_client.query("Select #{SF_ID} from #{prefixed_stripe_field(lookup_object)} where #{prefixed_stripe_field(lookup_field)} = '#{lookup_field_id}'") }
+
+    qla_data
+  end
 end
diff --git a/test/integration/translate/test_coupon.rb b/test/integration/translate/test_coupon.rb
@@ -30,7 +30,7 @@ class Critic::CouponTranslation < Critic::VCRTest
       sf_product_id, _sf_pricebook_id = salesforce_recurring_product_with_price
 
       # create a CPQ quote
-      sf_quote_id = create_salesforce_quote(sf_account_id: sf_account_id, contact_email: "order_and_order_line_when_quote_ordered", additional_quote_fields: {
+      sf_quote_id = create_salesforce_quote(sf_account_id: sf_account_id, contact_email: "order_and_order_line_when_quote_ordered_1", additional_quote_fields: {
         CPQ_QUOTE_SUBSCRIPTION_START_DATE => now_time_formatted_for_salesforce,
         CPQ_QUOTE_SUBSCRIPTION_TERM => TEST_DEFAULT_CONTRACT_TERM,
       })

diff --git a/...ts/test_amendments/phase_coupons_are_not_copied_over_to_new_phase_on_amendment_orders.yml b/...ts/test_amendments/phase_coupons_are_not_copied_over_to_new_phase_on_amendment_orders.yml
diff --git a/..._amendments/supports_adding_new_phase_and_phase_item_coupons_to_an_sf_amendment_order.yml b/..._amendments/supports_adding_new_phase_and_phase_item_coupons_to_an_sf_amendment_order.yml
diff --git a/.../translate/test_coupon/creates_a_new_stripe_coupon_if_the_sf_quote_coupon_is_modified.yml b/.../translate/test_coupon/creates_a_new_stripe_coupon_if_the_sf_quote_coupon_is_modified.yml
diff --git a/...late/test_coupon/order_and_order_line_coupons_are_created_when_an_sf_quote_is_ordered.yml b/...late/test_coupon/order_and_order_line_coupons_are_created_when_an_sf_quote_is_ordered.yml
diff --git a/...tion/translate/test_coupon/stripe_invoice_final_due_amount_takes_into_account_coupons.yml b/...tion/translate/test_coupon/stripe_invoice_final_due_amount_takes_into_account_coupons.yml
diff --git a/...late/test_coupon/translate_an_sf_order_with_coupons_on_both_the_order_and_order_items.yml b/...late/test_coupon/translate_an_sf_order_with_coupons_on_both_the_order_and_order_items.yml
diff --git a/...nslate/test_coupon/translate_sf_order_with_duration_repeating_coupon_on_an_order_line.yml b/...nslate/test_coupon/translate_sf_order_with_duration_repeating_coupon_on_an_order_line.yml
diff --git a/...ation/translate/test_coupon/translate_sf_order_with_multiple_coupons_on_an_order_line.yml b/...ation/translate/test_coupon/translate_sf_order_with_multiple_coupons_on_an_order_line.yml
diff --git a/...tegration/translate/test_coupon/uses_the_same_quote_stripe_coupon_if_translated_twice.yml b/...tegration/translate/test_coupon/uses_the_same_quote_stripe_coupon_if_translated_twice.yml
diff --git a/..._thrown_if_SF_Stripe_coupon_is_created_with_both_Amount_Off__c_and_Percent_Off__c_set.yml b/..._thrown_if_SF_Stripe_coupon_is_created_with_both_Amount_Off__c_and_Percent_Off__c_set.yml