Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Strimzi to use Fabric8 6.5.0 #8220

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 11, 2023

Type of change

  • Task

Description

This PR updates Strimzi to use Fabric8 6.5.0. This brings different changes, so this change is targeting only Strimzi 0.35 to make sure nothing got broken.

  • The deprecated calls in the test module are currently ignored. I would prefer to deal with them in a separate PR. If this is fine with the reviewers, issue will be opened before merging this.
  • The LeaderElection mock test does not work against Kubernetes Mock Server in 6.5.0 and it is disabled. We have a proper integration test covering the same, so I think this is fine to keep it disabled and wait if it is fixed in Fabric8. If this is fine with the reviewers, Strimzi issue will be opened before merging this.

Checklist

  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@scholzj scholzj added this to the 0.35.0 milestone Mar 11, 2023
@scholzj
Copy link
Member Author

scholzj commented Mar 11, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Mar 13, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj force-pushed the update-strimzi-to-use-fabric8-6.5.0 branch from 463fcb0 to a5d8bf5 Compare March 17, 2023 13:02
@scholzj scholzj marked this pull request as ready for review March 17, 2023 13:06
@scholzj scholzj requested a review from ppatierno March 17, 2023 13:06
@scholzj
Copy link
Member Author

scholzj commented Mar 17, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Mar 20, 2023

I opened some follow-up issues:

@scholzj scholzj force-pushed the update-strimzi-to-use-fabric8-6.5.0 branch from a5d8bf5 to 2b4eca3 Compare March 20, 2023 14:47
@scholzj scholzj merged commit cae598d into strimzi:main Mar 20, 2023
@scholzj scholzj deleted the update-strimzi-to-use-fabric8-6.5.0 branch March 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants