Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore LoadWICFile for Windows due to incomplete cross-platform functionality #2435

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Sep 8, 2024

PR Details

Partial revert of #2314 and #2338 for Windows to allow loading non-32-bit pixel formats.

Note that (as far as I'm aware) DxtWrapper.dll for Windows was not rebuilt with the 'dxtLoadWICFile' function removed, so it also means it does not need to be rebuilt for this revert.

Related Issue

Problem raised in #2376.
Technically it only fixes it for Windows, but the issue will persist for the non-Windows editor (which doesn't exist yet) and will require implementation/alternative solution if the intention is to remove it again.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title Restore LoadWICFile for Windows due to incomplete cross-platform functionality fix: Restore LoadWICFile for Windows due to incomplete cross-platform functionality Sep 8, 2024
@Eideren Eideren merged commit 0cfc464 into stride3d:master Sep 8, 2024
6 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Sep 8, 2024

Looks good, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants