Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust DirectXTex wrapper for all platforms #2314

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

This PR adds a Linux DxtWrapper binary file for Linux and a simple cmake script to replicate on other platforms . Additionally , my wrapper is based on the latest version of DirectXTex thanks to vcpkg - package manager for c++. I also added UTC32StringMarshaller because there is no support for Wide character on Linux.

  • - My change requires testing on Windows and if that is required,, update Windows shared library too.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (maybe?)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk
Copy link
Collaborator Author

Jklawreszuk commented Jun 7, 2024

Note: PR #2303 needs to be merged first (Done)

@Eideren
Copy link
Collaborator

Eideren commented Jun 18, 2024

Was about to start TC on this PR but you probably want to pull from master given you mentioned #2303 needs to be merged first ?

@Jklawreszuk
Copy link
Collaborator Author

@Eideren Correct! I rebased my branch now, so it should be ready for testing 👀

@Eideren Eideren merged commit f23ce73 into stride3d:master Jun 18, 2024
14 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Jun 18, 2024

Everything works as expected, thanks again @Jklawreszuk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants