Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rollback one of the TryAdd introduced through #2299, VS Package is still on net472 #2315

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jun 7, 2024

PR Details

See title, TryAdd doesn't exist on net472

Related Issue

#2299

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title Rollback one of the TryAdd introduced through #2299, VS Package is still on net472 fix: Rollback one of the TryAdd introduced through #2299, VS Package is still on net472 Jun 7, 2024
@Eideren Eideren merged commit b67eab4 into stride3d:master Jun 7, 2024
2 checks passed
@Eideren Eideren deleted the fix_pr_2299 branch June 7, 2024 19:47
@Kryptos-FR
Copy link
Member

Alternatively, it could be implemented as an extension method that only exists when compiling for net472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants