Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use tryadd instead of containskey guard clause #2299

Merged
merged 4 commits into from
May 30, 2024
Merged

fix: use tryadd instead of containskey guard clause #2299

merged 4 commits into from
May 30, 2024

Conversation

IXLLEGACYIXL
Copy link
Collaborator

PR Details

Uses the new NET8 TryAdd instead of ContainsKey guard clause + Add
It's faster as you dont need a double lookup in the dictionary

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Jklawreszuk
Jklawreszuk approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Jklawreszuk Jklawreszuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me

Eideren
Eideren reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@Eideren Eideren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small improvements

sources/engine/Stride.Physics/Engine/PhysicsComponent.cs Outdated Show resolved Hide resolved
sources/tools/Stride.TextureConverter/Backend/Wrappers/FINetWrapper/FreeImageWrapper.cs Outdated Show resolved Hide resolved
@IXLLEGACYIXL
Copy link
Collaborator Author

did all the review changes, i have everything i wanted for the pr

Kryptos-FR
Kryptos-FR approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Kryptos-FR Kryptos-FR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eideren Eideren merged commit 9a643ce into stride3d:master May 30, 2024
4 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 30, 2024

Thanks !

@Eideren Eideren added the area-Core Issue of the engine unrelated to other defined areas label May 30, 2024
Eideren added a commit to Eideren/xenko that referenced this pull request Jun 7, 2024
@Eideren
Rollback one of the TryAdd introduced through stride3d#2299, VS Packa…
bb85d97 
…ge is still on net472
@Eideren Eideren mentioned this pull request Jun 7, 2024
Merged
8 tasks
Eideren added a commit that referenced this pull request Jun 7, 2024
@Eideren
Rollback one of the TryAdd introduced through #2299, VS Package is st…
b67eab4 
…ill on net472 (#2315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eideren Eideren Eideren left review comments

@Jklawreszuk Jklawreszuk Jklawreszuk approved these changes

@Kryptos-FR Kryptos-FR Kryptos-FR approved these changes

Assignees
No one assigned
Labels
area-Core Issue of the engine unrelated to other defined areas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IXLLEGACYIXL @Eideren @Kryptos-FR @Jklawreszuk