Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop creating quests for private pitches #769

Merged
merged 1 commit into from
Jan 14, 2018

Conversation

matkoniecz
Copy link
Member

fixes handling of pitches inaccessible to public - for example pitches inside school

https://www.openstreetmap.org/note/1267483 is an example

it is quite rare, but without that in some location SC would be infinite source of notes

fixes handling of pitches inaccessible to public - for example pitches inside school

https://www.openstreetmap.org/note/1267483 is an example
@rugk
Copy link
Contributor

rugk commented Jan 14, 2018

Bus in your example one could guess/see (over the fence) what is played there. You'll certainly also see in a school whether they play basketball or football there. (not if there are houses/buildings around it and the school yard is in the middle, as in your link, but in many other cases)

@matkoniecz
Copy link
Member Author

Look again at that example. It is inside school, with building around - not just a fence.

It will exclude some private pitches that are visible over the fence but (1) private pitches are typically not tagged with access tag so loss will not be huge (2) it is better to avoid false positives at cost of false negatives.

@matkoniecz
Copy link
Member Author

If there is some viable alternative then I would update the PR but I am not aware about anything else that may be checked (I think that checking topology is not a viable solution)

@westnordost westnordost merged commit e4a0bea into streetcomplete:master Jan 14, 2018
@westnordost
Copy link
Member

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants