Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show opening_hours quest for sport_centre which belongs to a school #868

Closed
ENT8R opened this issue Feb 15, 2018 · 3 comments · Fixed by #870
Closed

Don't show opening_hours quest for sport_centre which belongs to a school #868

ENT8R opened this issue Feb 15, 2018 · 3 comments · Fixed by #870

Comments

@ENT8R
Copy link
Contributor

ENT8R commented Feb 15, 2018

I encountered some notes at a gym of a school which typically has no opening hours...
My proposal is to add !(leisure=sports_centre and building=school) somewhere in the query.
What do you think?
@matkoniecz
Copy link
Member

matkoniecz commented Feb 15, 2018 •
edited
Loading

Can you link examples of objects? For me it sounds like either mistagging or missing access=private.

@ENT8R
Copy link
Contributor Author

ENT8R commented Feb 15, 2018 •
edited
Loading

https://www.openstreetmap.org/note/1300146 which links to https://www.openstreetmap.org/way/99511882
Probably it should be access=private... But the opening hours quest doesn't exclude them yet... Maybe this should be the real enhancement here as I've found some other buildings/shops within private ground of e.g. a police academy...

@matkoniecz
Copy link
Member

I would exclude access=private like done in #769

@ENT8R ENT8R mentioned this issue Feb 15, 2018
Merged
@matkoniecz matkoniecz mentioned this issue May 6, 2018
Closed
@cyclingcat cyclingcat mentioned this issue Jun 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude private elements from opening_hours quest ENT8R/StreetComplete
2 participants
@matkoniecz @ENT8R