Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "bridge" from height limit texts, as pipelines and roofs will now appear as well #5918

Conversation

RubenKelevra
Copy link
Contributor

Additional fix for #5912

@westnordost
Copy link
Member

What? No, we already have a text for that, quest_maxheight_sign_title

@westnordost
Copy link
Member

Ah, but I see the issue... hmm...

@westnordost
Copy link
Member

It is now impossible to tell apart the situation "below a bridge", "below an overhead pipeline" and "below a building roof". So, I guess, the string should be removed for all. I hope this does not lead to confusion.

@RubenKelevra RubenKelevra deleted the maxheight_quest_generalize_text branch September 22, 2024 19:44
@RubenKelevra
Copy link
Contributor Author

I don't think so. I mean if you're standing on top of a bridge and it marks the road crossing blow on the map, I doubt anyone would think "there's no sign here on the bridge, let's put this in". :)

@mnalis
Copy link
Member

mnalis commented Sep 22, 2024

Although, I seem to recall discussions there was confusion even earlier, if the section of the road going under the bridge was long (i.e. the quest would pop up a kilometer before the bridge is even visible). I do not recall if a proper fix was devised; if not, making the text even more generic is likely to be even more confusing. E.g. #4588 ?

@westnordost
Copy link
Member

But there is no alternative, or is there?

@mnalis
Copy link
Member

mnalis commented Sep 22, 2024

But there is no alternative, or is there?

For the original confusion, or the new one?

  • for the original confusion (e.g. "What’s the height limit below the bridge"-quest does something wrong #4588), perhaps quest might be skipped if road segment going under the bridge is too long (maybe > 1km or something like that?) I don't know how complicated that would be, but it would reduce confusion (at the expense at not asking the quest in some situations)

  • for this newly increased confusion, getTitle() can be changed programmatically, like e.g. in air_pump/AddBicyclePump.kt. That would require separate translations, though, but would reduce the confusion to (much smaller) original levels.

Also quest description (the one behind info button) could be improved to at least mention all the things that this quest may apply to, and the fact that they may be somewhat far away.

@RubenKelevra
Copy link
Contributor Author

Although, I seem to recall discussions there was confusion even earlier, if the section of the road going under the bridge was long (i.e. the quest would pop up a kilometer before the bridge is even visible). I do not recall if a proper fix was devised; if not, making the text even more generic is likely to be even more confusing.

This highlights the main training issue I currently see in SC. Many beginners tend to walk to a quest marker, click on it, and then ignore the map, because the answer field opened up and draws their attention. Leading to them applying the information for the current situation the specific spot to the entire way. For longer ways, especially those over 200 meters, users who behave correctly still have to rely on memory, which becomes unreliable over such distances, leading to incorrect tagging.

My suggestion to address this could be implementing a prompt when a way exceeds 200 meters. The prompt would encourage them to split the way into smaller, manageable sections and only tag what they can visually confirm at the time of answering. This would prevent users from having to rely on memory, which often results in inaccuracies. By guiding users to divide the way into sections, they can tag each part with the appropriate information and avoid applying localized data across an entire way.

This approach could significantly improve data accuracy and reduce the common mistakes I’ve observed in OSM contributions from StreetComplete users.

The only draw back I see is that ways may be split up unnecessarily in some circumstances, but to be fair, that's better than having wrong information in the database IMHO.

@RubenKelevra
Copy link
Contributor Author

@westnordost thinking about it... It should be pretty easy to implement:

  • If the way of a quest is longer than 200m, show a popup:

"The way on the map is pretty long! Please mark on it how far you can see from your current location" (with an "OK" button on the right and a "skip" button on the left)

  • Then transition to the regular "split way" function, but limit it to two cuts and require at least one cut.
  • Afterwards reopen the quest for the middle section (on two cuts) or the small section (on one cut)

@westnordost
Copy link
Member

Nobody reads prompts of the "are you sure" type, though.

@westnordost
Copy link
Member

for this newly increased confusion, getTitle() can be changed programmatically, like e.g. in air_pump/AddBicyclePump.kt. That would require separate translations, though, but would reduce the confusion to (much smaller) original levels.

No, it can't, because passed into getTitle are the tags of the object for which the quest is created. In this case, the road below the roof or bridge. There is nothing tagged on that section of road that would help in deciding whether that section of road is below a bridge, roof or overhead pipeline.

@mnalis
Copy link
Member

mnalis commented Sep 22, 2024

There is nothing tagged on that section of road that would help in deciding whether that section of road is below a bridge, roof or overhead pipeline.

Ah, that is unfortunate if such information cannot be programmatically relayed further down the code.
Splitting the quest into three separate similar-looking quests would work instead I guess, but seems quite inelegant solution 🤔

If the way of a quest is longer than 200m, show a popup

While cutting would in the end reduce the confusion, I'm afraid that cure might be quite worse then the original illness if applied generally (spamminess, significant work multiplication, etc. See related #5101 for some of the issues).

However, applied just for the (rather rare) maxheight quest on too long ways there, such force-splitting might work (especially if they're instructed to just cut on the sides of the bridge)

@goldfndr
Copy link
Contributor

Instead of getTitle, could getLevelLabel (or a caller or other function) be overridden with another (or optional) parameter that would pass the overhead object and supplement the italicized description?

@westnordost
Copy link
Member

westnordost commented Sep 23, 2024

No, not possible.

I think the best compromise is to have a hint text that clarifies this, and also mentions splitting a way. Maybe something like....:

"This question is also asked for roads that runs under bridges, roofs etc..
If the highlighted section is much longer than the underpass itself, consider splitting up the way before answering."

Comments for this suggestion?

@mnalis
Copy link
Member

mnalis commented Sep 24, 2024

I'd add ", overhead pipes" before "etc...", but yes; it should help (provided people read it and are not overly confused)

westnordost added a commit that referenced this pull request Sep 25, 2024
FloEdelmann added a commit that referenced this pull request Sep 26, 2024
1. Double period
2. /n instead of \n

Those were introduced in cf83f80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants