Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roofs to maxheight quest #5915

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Add roofs to maxheight quest #5915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/src/main/java/de/westnordost/streetcomplete/quests/max_height/AddMaxHeight.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,13 @@ class AddMaxHeight : OsmElementQuestType<MaxHeightAnswer> {

private val bridgeFilter by lazy { """
ways with (
highway ~ ${(ALL_ROADS + ALL_PATHS).joinToString("|")}
or railway ~ rail|light_rail|subway|narrow_gauge|tram|disused|preserved|funicular|monorail
) and (
bridge and bridge != no
(
highway ~ ${(ALL_ROADS + ALL_PATHS).joinToString("|")}
or railway ~ rail|light_rail|subway|narrow_gauge|tram|disused|preserved|funicular|monorail
)
and bridge and bridge != no
) or (
building = roof
or man_made = pipeline and location = overhead
)
and layer
Expand All @@ -88,6 +91,7 @@ class AddMaxHeight : OsmElementQuestType<MaxHeightAnswer> {
&& tags["covered"] == null
&& tags["man_made"] != "pipeline"
&& tags["railway"] != "level_crossing"
&& tags["building"] != "roof"
// only the "below the bridge" situation may need some context
return when {
isBelowBridge -> R.string.quest_maxheight_sign_below_bridge_title
Expand Down