Add roofs to maxheight quest

[RubenKelevra]

• building=roof will show up for the max height quest
• man_made=pipeline will now also properly show up for this quest

Fixes #5912

[westnordost]

Thanks, and thanks for your fix, I think you are right!

[RubenKelevra]

@westnordost would you mind testing this change? I think it's not working. I've tried it and asked someone else to try it, and they confirmed it's now showing up for them either.

Case one:

Service road:

highway=service
lit=yes
smoothness=good
surface=paving_stones

Roof:

building=roof
layer=1 

Location: https://www.openstreetmap.org/#map=19/51.208604/7.231552&layers=N

Case 2:

Service road:

highway=service
surface=asphalt

Roof:

building=roof
layer=1
source=Bing

Location: https://www.openstreetmap.org/#map=19/48.482845/12.000903&layers=N

Versions tested: v60-alpha1 and v59.3

Screenshot

[mnalis]

@RubenKelevra is some quest is not working properly, I'd suggest opening a new issue (and just referencing the PR); instead of commenting on old, merged PRs (or old closed issues, for that matter) - where such report is likely to be overlooked.

[westnordost]

It's fine, I noticed

[westnordost]

I found the issue. The bridgeFilter expression is really just for linear bridge-features, not for areas.

[RubenKelevra]

Ah okay? I thought that's no issue as the way does cross the road anyway, regardless if closed or not.

Thanks for checking!