Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording of the crossing markings quest #5874

Conversation

RubenKelevra
Copy link
Contributor

Fixes #5872

@RubenKelevra
Copy link
Contributor Author

Sorry, Kate threw in some new lines at the end of some of the files. Can I leave that like this or should I clean it up?

@westnordost
Copy link
Member

Whooat? Where do all those translations come from? You didn't go through the effort to try to translate them all, did you?

@RubenKelevra
Copy link
Contributor Author

I've battled with ChatGPT for an hour or so and checked with Google Translate if the translation is precise.

@westnordost
Copy link
Member

Damn, I am sorry for that. It is wasted effort. Translations will be overwritten on the next import from POEditor. When a source string changes, all translations will automatically be marked as "fuzzy" in POEditor, so translators can have a look at the string and adapt the translation.
While you could logon to POEditor and change all those strings there too, I think it is always better to leave it to people actually speaking the language. (I wouldn't mind if you did, but it seems a lot of effort.)

From this PR, I'd prefer if you removed the changes to the translations because they will be overwritten anyway, as I stated.

@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Sep 5, 2024

Yeah, it's best to have them checked by a native speaker, but they should be fine.

For German, for example, the translation before was actually wrong — I'm a native speaker.

In German, it stated "Fußgängerüberweg" which means pedestrian crossing. But while the quest is confusingly named "quest_pedestrian_crossing_markings" a crossing in OSM could very well be a bicycle crossing or a mixed crossing.

That's why the English string does not specify it - I assume - but the translator saw probably the naming of the variable and assumed "pedestrian crossing" are meant.

If possible, it would be nice if the translators could just look over it and either modify or accept it. I thought that's what going to happen anyway. :)

@RubenKelevra RubenKelevra force-pushed the improve_crossing_quest_wording branch from 10ac736 to 3df1a71 Compare September 5, 2024 15:22
@westnordost
Copy link
Member

If possible, it would be nice if the translators could just look over it and either modify or accept it. I thought that's what going to happen anyway. :)

Nope, the translations are only synced one-way, i.e. from POEditor to this repo, never the other way round.

@westnordost westnordost merged commit 7eb4437 into streetcomplete:master Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossing Markings Quest - improve wording
2 participants