-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Quest: Does this caravan area have a sanitary_dump_station? #5363
New Quest: Does this caravan area have a sanitary_dump_station? #5363
Conversation
...in/java/de/westnordost/streetcomplete/quests/sanitary_dump_station/AddSanitaryDumpStation.kt
Outdated
Show resolved
Hide resolved
…y_dump_station/AddSanitaryDumpStation.kt Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
The pictures for the different resolutions all have the same resolution. But apart from this, I am really not sure if these pictures are that helpful. When not looking (very) closely, they just look like photos of a generic motorway lay-by with some signs. What do we have? We have
So, to me, the photos do not add a value, because (very tiny) you see the same sign again, and for the right picture, I don't even know where the sanitary dump station is supposed to be. Realisticially, such a facility would either be indicated by name, or by a well-known sign with an icon. So, what is missing to make sure that a surveyor with 0 knowledge about this can ascertain whether a place like this exists, is to show him how (else) this facility could be indicated, not some photos of how the place in general would look like. Not sure if there is a an official Vienna-convention sign for this, if there is, this should be shown instead. Just like it is done for example in the maxspeed quest when the user selects that it is a living street, see here: If no standardization exists, then might as well leave out the picture because not sure if showing many variations of how it may look like would be too helpful. |
Ok, so i can remove the image, just added this because of the comments in the issue that we need further explanation. I have no idea how we can make a better hint, but i asked the issue author. |
Well, as done for the maxspeed quests, certainly a picture could be helpful, but it should show (an) example(s) of how the sanitary dump station is indicated, not how it generally looks like. https://www.google.de/search?q=%22sanitary+dump+station%22+sign&tbm=isch If there is no standard, it may make sense to create an icon that is generic and similar enough to any national / regional standard that it can be recognized. (This is the reason why I created the graphics in https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/living%20street myself, because each is a simplification of the design - otherwise there would have to be individual graphics for each different country as in each different country, it looks slightly different) |
Hm, two times basically the same sign, a bit German(?)-centric. But that's okay, I might draw up some own icons myself after merge. (I wanted to do that for the quest icon anyway, as it is not so consistent with the style of other quest icons (too monochrome, too fine details). |
@qugebert The two variants were intended more as "either A or B", not both at the same time 😄 I would take the right / blue-filled one, as the visibility is better there. |
Ich würde den Text weglassen, da den sonst (theoretisch) in der Grafik in alle verfügbaren Sprachen übersetzen müsste. Die Grafik sagt auch ohne Text genug aus. |
Stimmt, das mit der Übersetzung hatte ich nicht bedacht, ich lasse den Text weg. |
Dankeschön :) |
Thank you for the new quest. Please update the query under: In the wiki there is only |
Thanks for finding this @sun-geo! Would you like to update this yourself and send a pull request? |
I updated it, see request: #5407 |
Closes #5233