Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this caravan area have a sanitary_dump_station ? #5233

Closed
petitminion opened this issue Sep 3, 2023 · 15 comments · Fixed by #5363
Closed

Does this caravan area have a sanitary_dump_station ? #5233

petitminion opened this issue Sep 3, 2023 · 15 comments · Fixed by #5363
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@petitminion
Copy link

petitminion commented Sep 3, 2023

This is a proposition to tag objects tagged with this tag : caravan_site

General

Affected tag(s) to be modified/added: sanitary_dump_station
Question asked: Does this caravan area have a sanitary_dump_station?
response : yes/no/custumors

same could be done for theses tags :

Checklist

Checklist for quest suggestions (see guidelines):

  • [ x ] 🚧 To be added tag is established and has a useful purpose
  • [ x ] 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • [ x ] 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • [ x ] 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • [ x ] 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

Element selection:

Metadata needed:

Proposed UI:

@mnalis
Copy link
Member

mnalis commented Sep 4, 2023

@mnalis
Copy link
Member

mnalis commented Sep 4, 2023

@petitminion Although, it would probably be a better idea to open a separate issue for each of the quests requested (IOW, keep it one-quest-per-issue). i.e. keep this one exclusively about sanitary_dump_station, and create two new issues for other two quests.

Because implementing one of them would likely close the whole issue (as seen #5206), and even if doesn't, it will make discussing several different quests in the same issue hard to follow.

@rhhsm
Copy link

rhhsm commented Sep 7, 2023

I don't think it fulfils "Easily answerable by any pedestrian from the outside but a survey is necessary": I wouldn't know how to look for one. Are they visible from the outside (outside the area, if it is not publicly accessible)?

@mnalis
Copy link
Member

mnalis commented Sep 7, 2023

perhaps override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside like we have for other quests that require entering the shop/restaurant?

If I understand correctly linked issue (and judging from the picture at tourism=caravan_site, the caravans are prevented by entering by having to pay for barrier=lift_gate or similar to allow the vehicle in, but pedestrians can roam around?

@petitminion
Copy link
Author

petitminion commented Sep 7, 2023

yes pedestrians can easily access a caravan_site :)

Also most of the time there is a sign indicating if the service is present :

Sadly I didn't find any open source image to add to the wiki but I will do it when I find a panel on the road o/

We could add the 4 photos to the quest so people understand:

@qugebert
Copy link
Contributor

qugebert commented Sep 8, 2023

If I understand correctly linked issue (and judging from the picture at tourism=caravan_site, the caravans are prevented by entering by having to pay for barrier=lift_gate or similar to allow the vehicle in, but pedestrians can roam around?

I only know a few of them, but yes, its mostly just some seperate parking space on a normal parking site with some additional equipment (dump station etc,). And we ask for various things on camping sites too, these are more likely not accessible for non-customers.

I can do the implementation if it is okay (and if someone can provide a icon with compatible license)

@mcliquid
Copy link
Contributor

I've added two images to wikimedia if this helps:
https://commons.wikimedia.org/wiki/File:Sanitary_dumb_station-platja-brava.jpg
https://commons.wikimedia.org/wiki/File:Sanitary-dump-station-sign.jpg

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Oct 20, 2023
qugebert added a commit to qugebert/StreetComplete that referenced this issue Oct 30, 2023
@qugebert
Copy link
Contributor

qugebert commented Oct 30, 2023

So here is my draft.
I took the description from the wiki, is this ok or are there any suggestions for another text?
And are these two pictures enough? Isn't the quest form too high if we add another row?
Is green the correct color for the marker (amenities) or should it be yellow (motor vehicles) ?

Screenshot_20231030-235233

@rhhsm
Copy link

rhhsm commented Oct 31, 2023

Looks good, including the quest pin. I'm glad you didn't use the word "caravan" because that would confuse me (and probably many others).
The sentence could be shortened a bit, maybe "Facility for depositing human waste from a toilet holding tank of a motorhome, long haul truck, etc. Might look like this:"

@qugebert
Copy link
Contributor

qugebert commented Nov 7, 2023

@petitminion @mcliquid see #5363 (comment)
any ideas?

@mcliquid
Copy link
Contributor

mcliquid commented Nov 7, 2023

@qugebert From my experience, at least in Europe, two signs (which look very similar) are common. I have vectorized the more common one myself:
sanitary_dump_station

And one alternative with the white circle:
sanitary_dump_station_2

Source for the RV: https://en.wikipedia.org/wiki/File:Zusatzzeichen_1048-17_-_nur_Wohnmobile,_StVO_1992.svg
The rest was arranged by me from the sign you can find if you google "verkehrszeichen wohnmobil entsorgung".

If you like, I can finalize the sign and make it available to you as an SVG.

@qugebert
Copy link
Contributor

qugebert commented Nov 7, 2023

Also ich habe jetzt nochmal bisschen gegoogelt und im Grunde sehen die Schilder alle recht ähnlich aus. Entweder Wohnmobil oder -anhänger über einer Mulde und dazu der Pfeil. Hintergrund blau oder braun, ggf. horizontal gespiegelt. Ich hab's auch mit Google translate versucht für verschiedene Sprachen (russisch, türkisch, etc.) und das Ergebnis in die Bildersuche gepackt, da kam leider nichts brauchbares raus. Ich weiss nicht wirklich wie ich das mit der Illustration jetzt machen sollte.

@mcliquid
Copy link
Contributor

mcliquid commented Nov 7, 2023

Quick research on wikidata
Wikidata-Item
Check out the signs here: https://commons.wikimedia.org/wiki/Category:Effluent_waste_disposal_signs

Some international synonyms:
English naming: black water / wastewater disposal / tank dump station
German naming: Abwasser / Grauwasser / Toilettenentsorgung
French naming: Eaux noires / Eaux usées / station de vidange
Italian naming: Acque nere / Acque di scarico / camping service
Spanish naming: Aguas negras / Aguas grises /
Dutch naming: Zwart water / Grijs water

Icons on other platforms:
park4night.com (one of the biggest RV platforms, comparable to AirBnb):
image
See in full size:
https://cdn6.park4night.com/images/svg/icons/services/service_eau_usee.svg
https://cdn6.park4night.com/images/svg/icons/services/service_eau_noire.svg

opencampingmap: only a arrow down in a rectangle
image

After the little research I would either go with my first suggestion (motorhome on water waves). Or the toilet on water waves like at park4night. I can create a simple icon for you if you want to.

@qugebert
Copy link
Contributor

qugebert commented Nov 7, 2023

I can create a simple icon for you if you want to.

Sure, this would help a lot.

@mcliquid
Copy link
Contributor

mcliquid commented Nov 7, 2023

westnordost added a commit that referenced this issue Nov 26, 2023
* Draft AddSanitaryDumpStation

#5233

* Update AddSanitaryDumpStation.kt

* add sanitary_dump_station example pic

* AddSanitaryDumpStation: Improve elementFilter

* Create sanitary_dump_station_illustration.jpg

* drawables

* Update quest_sanitary_dump_station.xml

* fix drawables

* Update strings.xml

* Update app/src/main/java/de/westnordost/streetcomplete/quests/sanitary_dump_station/AddSanitaryDumpStation.kt

Co-authored-by: Flo Edelmann <[email protected]>

* Update app/src/main/res/authors.txt

Co-authored-by: Flo Edelmann <[email protected]>

* remove image

* examlple signs for sanitary dump station

* alternative sign

* new pictures

* remove  attribution to missing picture

---------

Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Tobias Zwick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants