Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask "Is this inside a building" #5278

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

qugebert
Copy link
Contributor

So, after something went wrong with my last PR #5248 (i tried to pull the latest version of the main branch for testing), i created a new fork and PR
Related Issue: #5175

See also the discussion at #5248 but i think i now made all requested changes.

Co-authored-by: Flo Edelmann <[email protected]>
@FloEdelmann FloEdelmann linked an issue Oct 1, 2023 that may be closed by this pull request
5 tasks
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to still make an icon for that.

By the way, for this level of complexity regarding the filter, it's always useful to have some test cases. But not required for this to get merged.

@westnordost westnordost self-assigned this Oct 11, 2023
@westnordost westnordost removed their assignment Oct 11, 2023
@westnordost westnordost merged commit bb89442 into streetcomplete:master Oct 13, 2023
@qugebert qugebert deleted the amenity_indoor branch October 13, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask "Is this inside a building?"
3 participants