Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask "Is this inside a building?" #5175

Closed
4 of 5 tasks
westnordost opened this issue Aug 5, 2023 · 5 comments · Fixed by #5278
Closed
4 of 5 tasks

Ask "Is this inside a building?" #5175

westnordost opened this issue Aug 5, 2023 · 5 comments · Fixed by #5278
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@westnordost
Copy link
Member

westnordost commented Aug 5, 2023

General

Affected tag(s) to be modified/added: indoor=yes/no
Question asked: Is this inside a building?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose:
    Small objects are hard to find on a survey; adding the information whether it is inside or outside helps verifiability and also helps indoor renderers
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
    Well, if it is not outside, it is probably inside (except if it does not exist). POIs inside buildings are usually only mapped for buildings that are publicly accessible (malls, train stations, ...)
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
    Didn't check

Ideas for implementation

Element selection: All POIs of certain types within building outlines (or optionally also: just outside of building outlines) that have neither indoor nor level, level:ref, location etc. tagged

POIs to ask for:

Implementation

Very straightforward, just copy/replace AddIsDefibrillatorIndoor and adapt it accordingly to include other POIs too.


Implementation of this unblocks #5170.

cc @HolgerJeromin - your first quest?

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Aug 5, 2023
@qugebert
Copy link
Contributor

@HolgerJeromin So do you want to implement this or can i try this?

And i think copy&paste from AddIsDefibrillatorIndoor ist not too obvious, because the highlightning there is hardcoded for only one element type. You need to adapt some Logik from CheckExistence-Quest to make it flexible, that always the neighbouring elements of the same type are displayed (for example, if asked for atm, display other atms, not other defibrillators).

@HolgerJeromin
Copy link
Contributor

@qugebert Feel free to go ahead. I will not have time to implement this.

@qugebert
Copy link
Contributor

Is this element selection ok?

nodes with
(
emergency = defibrillator
or emergency = fire_extinguisher
or amenity = atm
or amenity = telephone
or amenity = parcel_locker
or amenity = luggage_locker
or amenity = locker
or amenity = clock
or amenity = post_box
or amenity = public_bookcase
or amenity = give_box
or amenity = vending_machine and vending ~ parking_tickets|public_transport_tickets
or amenity = ticket_validator
)
and access !~ private|no
and !indoor and !location

I'm not sure about the last 4 (public_bookcase,give_box,vending_machine,ticket_validator) but taginfo listed them as sometimes combined with indoor=yes

And should we enable the 'delete Element' Function? It was disabled for the defibrillator-task.

@mnalis
Copy link
Member

mnalis commented Sep 3, 2023

Is this element selection ok?

Looks reasonable to me. Although in StreetComplete AFAIK it is more commonly written with regexp, e.g. convert those multiple lines to ... or amenity ~ atm|telephone|parcel_locker|luggage_locker|...

@westnordost
Copy link
Member Author

Ah, missed this comment. Yes, the form as @mnalis is faster too, by the way.

The list looks fine. However, since it shall only be asked for nodes inside (or near-inside, if it is not too performance-intensive to implement), it could be expanded. E.g. it is common that sweets vending machines are inside malls etc. too.

We started to create a list of (street) furniture in the linked doc from #4912. But anyway, I figure this is something that could always be expanded later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
4 participants