-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask "Is this inside a building?" #5175
Comments
@HolgerJeromin So do you want to implement this or can i try this? And i think copy&paste from AddIsDefibrillatorIndoor ist not too obvious, because the highlightning there is hardcoded for only one element type. You need to adapt some Logik from CheckExistence-Quest to make it flexible, that always the neighbouring elements of the same type are displayed (for example, if asked for atm, display other atms, not other defibrillators). |
@qugebert Feel free to go ahead. I will not have time to implement this. |
Is this element selection ok? nodes with I'm not sure about the last 4 (public_bookcase,give_box,vending_machine,ticket_validator) but taginfo listed them as sometimes combined with indoor=yes And should we enable the 'delete Element' Function? It was disabled for the defibrillator-task. |
Looks reasonable to me. Although in StreetComplete AFAIK it is more commonly written with regexp, e.g. convert those multiple lines to |
Ah, missed this comment. Yes, the form as @mnalis is faster too, by the way. The list looks fine. However, since it shall only be asked for nodes inside (or near-inside, if it is not too performance-intensive to implement), it could be expanded. E.g. it is common that sweets vending machines are inside malls etc. too. We started to create a list of (street) furniture in the linked doc from #4912. But anyway, I figure this is something that could always be expanded later. |
General
Affected tag(s) to be modified/added: indoor=yes/no
Question asked: Is this inside a building?
Checklist
Checklist for quest suggestions (see guidelines):
Small objects are hard to find on a survey; adding the information whether it is inside or outside helps verifiability and also helps indoor renderers
Well, if it is not outside, it is probably inside (except if it does not exist). POIs inside buildings are usually only mapped for buildings that are publicly accessible (malls, train stations, ...)
Didn't check
Ideas for implementation
Element selection: All POIs of certain types within building outlines (or optionally also: just outside of building outlines) that have neither
indoor
norlevel
,level:ref
,location
etc. taggedPOIs to ask for:
amenity=parcel_locker
(see Is this parcel locker inside a building? #5098)amenity=clock
(see Showindoor=yes
(at least for clocks) in quest #5170)emergency=defibrillator
(replacesAddIsDefibrillatorIndoor
quest)amenity=atm
Implementation
Very straightforward, just copy/replace
AddIsDefibrillatorIndoor
and adapt it accordingly to include other POIs too.Implementation of this unblocks #5170.
cc @HolgerJeromin - your first quest?
The text was updated successfully, but these errors were encountered: