Incorrect tactile paving option for crossings #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoniecz
approved these changes
Mar 5, 2022
|
I was about to comment about that, because answering "on one side only" does not make sense when the app asks about just one kerb or just a bus stop. It is confusing (to read) to have such an answer option when it is not used. Please instead just create a |
|
Fair enough Tested and working as expected |
westnordost
approved these changes
Mar 5, 2022
.../main/java/de/westnordost/streetcomplete/quests/tactile_paving/TactilePavingCrosswalkForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/tactile_paving/TactilePavingAnswer.kt
Outdated
Show resolved
Hide resolved
|
Thanks for doing the shortening, could have sworn I'd already done that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3813
As the same form is used for all tactile paving quests, showing the incorrect option only for nodes with
highway=crossingorhighway=traffic_signals(in the same way as the steps answer option in path quests) seemed like the best way of doing it.