allow marking objects as without opening hours sign [prepare for a tag replacement] #1118

matkoniecz · 2018-07-03T17:11:44Z

rugk · 2018-07-03T17:22:31Z

Being unable to collect information != No signs with these information.

E.g. it could be access restricted, not thgere any more, etc. All things, which would require the user to select the "add note" instead.

So i'd suggest to reword the warning message to make that clear. The menu item is quite fine, IMHO.

matkoniecz · 2018-07-03T18:11:59Z

reword the warning message to make that clear

Do you have any idea what would fit? Maybe back to earlier "Are you sure that there is no sign with opening hours info?"

rugk · 2018-07-03T19:37:04Z

Yes, that's a bit clearer e.g.

westnordost

👍
I will merge this for the next major version, best together with the other *:signed quest you made

westnordost · 2018-07-07T22:55:26Z

app/src/main/res/values/strings.xml

@@ -453,6 +453,9 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards
    <string name="invalidate_confirmation">Invalidate</string>
    <string name="invalidation_dialog_message">Invalidating the cache causes the quests to be updated next time they are downloaded. The quest cache is invalidated automatically after one week and immediately when a quest you solved turns out to be already answered by someone else.</string>
    <string name="quest_openingHours_emptyAnswer">You need to describe what is on the sign. If there is no sign, you should ask for the opening hours inside.</string>
+    <string name="quest_openingHours_no_sign">Opening hours are unknown</string>


Actually, it should say "No opening hours sign"

I wanted to avoid discouraging people from asking about opening hours. People should use this option only when there is no opening hours sign and there are unable/unwilling to collect it by other means (usually asking worker inside).

But this is exactly what the opening_hours:signed tag is about.

I agree but I think that there are three situations

opening hours are signed (tag opening_hours)

opening hours are not signed, one is willing and able to collect them anyway (maybe shop is without customers and one is able to ask shopkeeper, maybe one has a local knowledge, maybe...) -> tagging opening_hours and tagging opening_hours:signed=no is correct but tagging opening_hours is preferable

opening hours are unsigned, one is unable or unwilling to collect the opening hours data -> tag opening_hours:signed

For the second case I wanted to avoid tagging opening_hours:signed but I may change that if you are sure.

@westnordost

I may change that if you are sure

ping?

Yes, please do.
For the second case, users are slightly encouraged to collect them anyway because the not-signed answer is hidden in the other answers submenu

matkoniecz · 2018-07-08T07:30:26Z

best together with the other *:signed quest you made

Which one? I would be happy to make PR but I am not sure for which quest it would be useful.

westnordost · 2018-07-08T11:51:07Z

collection_times:signed

matkoniecz · 2018-07-09T08:12:41Z

OK, I will make it (after making final interface decision here in discussion above).

matkoniecz · 2018-07-15T13:24:27Z

collection_times:signed

I think that given that this change are supposed to be added together I will add it to this PR.

matkoniecz · 2018-07-18T20:06:19Z

I wonder what should be done with note:collection_times

My current plan based on https://taginfo.openstreetmap.org/keys/note%3Acollection_times#values is to drop support for this tag as part of the PR and close to release retag it (to collection_times:signed or collection_times, depending on its content)

fixes streetcomplete#1076

westnordost · 2018-07-20T14:12:21Z

I agree, dropping support would be fine, and changing the already existing note:collection_times=no␣times␣specified␣on␣the␣box tags would be good (after the changes went live)

It is by the way super convenient for me that you put the current status in the title 👍

matkoniecz · 2018-07-20T14:21:24Z

It is by the way super convenient for me that you put the current status in the title +1

Great! I worried a bit that each title change may send notifications/mail/whatever and I was not sure is it a good idea (I was doing it to avoid getting lost in a stack of PRs).

Now I can stop worrying :)

# Conflicts: # app/src/main/res/values/strings.xml

westnordost · 2018-08-15T20:09:59Z

You already dropped support for note:collection_times

westnordost · 2018-08-15T20:23:51Z

done, tested.
It would be great if you put "prepare for a tag replacement" on your internal todo list, naturally this PR is closed automatically when this is merged, which I am doing now.

matkoniecz · 2018-08-15T21:18:27Z

Sorry, I had no time recently - and thanks for finishing this!

matkoniecz mentioned this pull request Jul 5, 2018

allow "there is no opening hours sign" answer to opening hours quest #1076

Closed

westnordost reviewed Jul 7, 2018

View reviewed changes

matkoniecz changed the title ~~allow marking objects as without opening hours sign~~ allow marking objects as without opening hours sign [waiting for a confrmation] Jul 11, 2018

matkoniecz changed the title ~~allow marking objects as without opening hours sign [waiting for a confrmation]~~ allow marking objects as without opening hours sign [waiting for a confirmation] Jul 11, 2018

matkoniecz changed the title ~~allow marking objects as without opening hours sign [waiting for a confirmation]~~ allow marking objects as without opening hours sign [waiting for fix by author] Jul 15, 2018

matkoniecz changed the title ~~allow marking objects as without opening hours sign [waiting for fix by author]~~ allow marking objects as without opening hours sign [waiting for confirmation that dropping support for note:collection_times is a good idea + testing] Jul 18, 2018

matkoniecz added 4 commits July 20, 2018 15:24

allow marking objects as without opening hours sign

6841f85

fixes streetcomplete#1076

tweak again wording of question

a335f3c

switch from 'note:collection_times' to 'collection_times:signed'='no'

f51ace7

stop encouraging to ask about opening hours

b03b174

matkoniecz force-pushed the unsigned_opening_hours branch from 1ab9a46 to b03b174 Compare July 20, 2018 13:25

westnordost added 2 commits August 15, 2018 21:59

Merge branch 'master' into unsigned_opening_hours

be88b85

# Conflicts: # app/src/main/res/values/strings.xml

fix test

289cbf6

westnordost changed the title ~~allow marking objects as without opening hours sign [drop support for note:collection_times, prepare for a tag replacement + testing]~~ allow marking objects as without opening hours sign [prepare for a tag replacement + testing] Aug 15, 2018

remove superfluous (IMO) strings

b17950a

westnordost changed the title ~~allow marking objects as without opening hours sign [prepare for a tag replacement + testing]~~ allow marking objects as without opening hours sign [prepare for a tag replacement] Aug 15, 2018

westnordost merged commit d11226e into streetcomplete:master Aug 15, 2018

matkoniecz deleted the unsigned_opening_hours branch November 26, 2018 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow marking objects as without opening hours sign [prepare for a tag replacement] #1118

allow marking objects as without opening hours sign [prepare for a tag replacement] #1118

matkoniecz commented Jul 3, 2018

rugk commented Jul 3, 2018

matkoniecz commented Jul 3, 2018

rugk commented Jul 3, 2018

westnordost left a comment •

edited

Loading

westnordost Jul 7, 2018

matkoniecz Jul 8, 2018

westnordost Jul 8, 2018

matkoniecz Jul 9, 2018 •

edited

Loading

matkoniecz Jul 15, 2018

westnordost Jul 15, 2018

matkoniecz Jul 18, 2018

matkoniecz commented Jul 8, 2018

westnordost commented Jul 8, 2018

matkoniecz commented Jul 9, 2018

matkoniecz commented Jul 15, 2018

matkoniecz commented Jul 18, 2018

westnordost commented Jul 20, 2018

matkoniecz commented Jul 20, 2018

westnordost commented Aug 15, 2018

westnordost commented Aug 15, 2018

matkoniecz commented Aug 15, 2018

allow marking objects as without opening hours sign [prepare for a tag replacement] #1118

allow marking objects as without opening hours sign [prepare for a tag replacement] #1118

Conversation

matkoniecz commented Jul 3, 2018

rugk commented Jul 3, 2018

matkoniecz commented Jul 3, 2018

rugk commented Jul 3, 2018

westnordost left a comment • edited Loading

Choose a reason for hiding this comment

westnordost Jul 7, 2018

Choose a reason for hiding this comment

matkoniecz Jul 8, 2018

Choose a reason for hiding this comment

westnordost Jul 8, 2018

Choose a reason for hiding this comment

matkoniecz Jul 9, 2018 • edited Loading

Choose a reason for hiding this comment

matkoniecz Jul 15, 2018

Choose a reason for hiding this comment

westnordost Jul 15, 2018

Choose a reason for hiding this comment

matkoniecz Jul 18, 2018

Choose a reason for hiding this comment

matkoniecz commented Jul 8, 2018

westnordost commented Jul 8, 2018

matkoniecz commented Jul 9, 2018

matkoniecz commented Jul 15, 2018

matkoniecz commented Jul 18, 2018

westnordost commented Jul 20, 2018

matkoniecz commented Jul 20, 2018

westnordost commented Aug 15, 2018

westnordost commented Aug 15, 2018

matkoniecz commented Aug 15, 2018

westnordost left a comment •

edited

Loading

matkoniecz Jul 9, 2018 •

edited

Loading