-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow "there is no opening hours sign" answer to opening hours quest #1076
Comments
What should it do of that option is selected? |
Hide quest, add tag noting this information, Places with tagged missing opening hours sign would not appear in this quest. Maybe as bonus one may create separate quest "missing opening hours, requires more research as opening hours sign is missing". |
If this tag is going to be accepted, it would be a good improvement to the app if it was used. You mention a discussion on a mailing list, but I cannot find anything. |
I contributed to the discussion in the wiki (FYI) https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/opening_hours:sign%3Dno |
By the way, I was meaning to ask: Why Zażółć? |
I wanted to ensure that bugs/poor ideas introduced in my fork will not get blamed on StreetComplete. But maybe I should change it "Zażółć (fork of StreetComplete)" |
I meant to ask what Zażółć means |
"Zażółć" can be translated as "make it yellow". I had no good idea for name and it is planned as a personal fork used just by me, so I was not thinking long about a name. |
Did you read https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/opening_hours:sign%3Dno#Use_.2A:signed_rather_than_.2A:sign_.3F ? I would implement |
OK, I will improve & update my code and submit it as a PR. EDIT: submitted as #1118 |
I am happy with walking along street and transcribing opening hours sign, but I am not interested going inside shops/night clubs/etc and asking people about opening hours schedule.
So I implemented this feature in my fork and I would be happy to improve our to standards of SC - currently text is not fitting message box and I want to finish discussion on using mailing list.
Implementation that would be base for PR: matkoniecz@7bfb471
The text was updated successfully, but these errors were encountered: