Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycleway overlay marks both sides of roundabout as missing #5716

Closed
FloEdelmann opened this issue Jul 2, 2024 · 4 comments · Fixed by #5961
Closed

Cycleway overlay marks both sides of roundabout as missing #5716

FloEdelmann opened this issue Jul 2, 2024 · 4 comments · Fixed by #5961
Assignees

Comments

@FloEdelmann
Copy link
Member

FloEdelmann commented Jul 2, 2024

How to Reproduce
For https://osm.org/way/492794174 (OSM element version 11), the cycleway quest correctly recognizes that it's a oneway street (implied by junction=roundabout but not explicitly set with oneway=yes). The cycleway overlay however does not recognize this and marks both sides as red:

Screenshot_20240702-141300_Street­Complete Screenshot_20240702-141318_Street­Complete

Expected Behavior
The cycleway overlay should also only mark the outer side as red, and possibly also only allow setting the outer side.

Versions affected
StreetComplete v58.1, Android 13

@FloEdelmann FloEdelmann added the bug label Jul 2, 2024
@FloEdelmann

This comment was marked as resolved.

@westnordost

This comment was marked as resolved.

@westnordost
Copy link
Member

Short answer: Will not fix.

Long answer:
In the quest, oneways (which include roundabouts) are treated specially, to not (uselessly) ask for cycle tracks in contraflow of oneways as most oneways do not have that. This is not done for overlays because overlays should offer a more immediate interface for setting and updating the cycleway infrastructure tagging. I don't think it is necessary to add complexity here to hide stuff from the user as it would be done for quests.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@westnordost westnordost reopened this Jul 6, 2024
@westnordost
Copy link
Member

westnordost commented Jul 6, 2024

I just noticed/remembered that we already do some filtering where cycletracks are not expected and that these are then shown as transparent instead of red. E.g. motorroads missing cycleway are not highlighted red (but transparent).

So, while not a bug, it can certainly be an improvement to add this. Additionally, I would say that the following taggings are all equally unlikely to have cycle tracks in contraflow:

  • roundabouts
  • oneways with dual_carriageway=yes
  • oneways that are a *_link roads

@westnordost westnordost self-assigned this Aug 14, 2024
westnordost added a commit that referenced this issue Oct 14, 2024
westnordost added a commit that referenced this issue Oct 14, 2024
westnordost added a commit that referenced this issue Oct 14, 2024
westnordost added a commit that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants