Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows a missing cycleway on one side if the other side has any cycleway information #5722

Closed
Langlaeufer opened this issue Jul 5, 2024 · 7 comments
Assignees

Comments

@Langlaeufer
Copy link

Langlaeufer commented Jul 5, 2024

Visualization in Cycleway-Overlay

bicycle_road=yes
oneway=yes
oneway:bicycle=no

yellow dashed line with red right border and black dashed left border.

image
https://www.openstreetmap.org/way/7979092

Expected Behavior
should not be red bordered because there is no cycleway-tag missing on a bicycle_road

Versions affected
SCEE 58.1

@Langlaeufer Langlaeufer added the bug label Jul 5, 2024
@Langlaeufer Langlaeufer changed the title cycleway-overlay. bicycle_road with oneway=yes oneway:bicycle=no Shows a missing right cycleway on a bicycle_road with oneway:bicycle=no Jul 5, 2024
@westnordost
Copy link
Member

This is not a bug.

There is no cycleway tag on the way linked, therefore it is shown that this information is missing. It is physically possible for bicycle roads to have cycleways, e.g. if the physical cycleway has not been removed after a road has been designated as a bicycle road. (The designation just requires a sign, while the removal of a possible prior cycleway requires re-construction of the road, hence it probably that both don't happen at the same time).

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
@westnordost
Copy link
Member

westnordost commented Jul 5, 2024

I do wonder, though, why Alleestraße has nothing highlighted?

@Langlaeufer
Copy link
Author

Langlaeufer commented Jul 6, 2024

That's not a good argument. There are usually no cycleways on either bike streets or 30 km/h zones, so SC doesn't show red borders there. As this logic isn't followed for one-way streets with bicycle except, I call it a bug.

While it is still possible to manipulate the cycleway tags for 30 km/h zones, this is not possible with bicycle_road=yes in SC - here the user would first have to remove the bicycle_road.

The bug was introduced with the deprecation of cycleway=opposite and only bicycle_roads with oneway:bicycle=no are affected.

@Langlaeufer
Copy link
Author

BTW: Wenn du möchtest dass SC betreffende Dinge hier und nicht in der SC Community diskutiert werden, solltest du meiner Meinung nach etwas Diskussion abwarten bevor Fehlermeldungen geschlossen werden.

@westnordost
Copy link
Member

westnordost commented Jul 6, 2024

Chill, man. I closed the issue because you posted it as a bug. I tend to treat bug reports that are not bugs like answered questions - I close them. You can also post enhancement requests.

Anyway, good point. I forgot that there is already some filtering done that conditionally does not show a missing cycleway in red but as transparent instead. I would be consistent to extend that to bicycle roads. Let's treat this as an enhancement request.

@westnordost westnordost reopened this Jul 6, 2024
@westnordost
Copy link
Member

Hmm, actually, bicycle_roads are already in that filter. The reason why it is highlighted anyway is that if a road has any information that is displayed for one side (i.e. in this case - "none but contraflow allowed"), then the other side is always shown as red when there is no information.

Not sure why I implemented it like that, though. Maybe that could be dropped.

@westnordost westnordost changed the title Shows a missing right cycleway on a bicycle_road with oneway:bicycle=no Shows a missing cycleway on one side if the other side has any cycleway information Jul 6, 2024
@westnordost
Copy link
Member

Contemplating it, I think this should be dropped and whether a missing cycleway should be shown in red should be decided individually per-side, also in light of #5716

@westnordost westnordost self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants