Don't use disused:shop=yes on non-shops

[Discostu36]

When an amenity, healthcare facility, etc. is closed, SC adds disused:shop=yes. See, for example, here. This is adding wrong data, as the lifecycle prefix should match the former tag.

How to Reproduce

I guess this happens every time that you mark a location as vacant.

Expected Behavior

The (former) main tag of the facility should be altered by adding a disused: in front, like explained in the wiki.

Versions affected

SC 56.0, probably also later, there was no mention in the changelogs.

[Discostu36]

If you want to avoid using the value because it could be incorrect, as @matkoniecz argued in #2707 (comment), at least the key should be preserved, e.g. disused:amenity=yes.

[westnordost]

This is more of a missing feature than a bug, but I agree, it should be done. (Or, use shop=vacant after all.)

Unfortunately, the code for this is quite scattered right now and assumes that tags like disused:amenity (...office, club, craft, ... ) are not used, so this all should be handled in a newly to be defined function named e.g. fun makeDisused(tags: Tag) or similar in de/westnordost/osm/Lifecycle.kt (or similar).

(If someone wants to contribute this, start with searching for usages of "disused:shop" in the code.)

[matkoniecz]

This is more of a missing feature than a bug, but I agree, it should be done. (Or, use shop=vacant after all.)

If disused:shop=yes is bad in case of emptied amenity then surely shop=vacant is also bad?

For shop-like amenities disused:shop=yes seems not worse than disused:amenity=yes to me.

[Helium314]

For disused amenities I think it's be better to keep the value. disused:amenity=yes could also be a disused waste bin, vending machine or car park.

[westnordost]

I am contemplating whether to return using shop=vacant. The tag is not going to go away, after all, so might as well use it. Its meaning is more broad, i.e. other than disused:shop=yes I'd say it includes

• shops that have always been vacant (e.g. newly constructed shops), i.e. never had a tenant

• it describes the shop space being vacant, i.e. the now, rather than what it was before (disused:*)

[mnalis]

If you're looking for a feedback, I do not like either shop=vacant or (hardcoded) disused:shop=yes. For example, I am asked if tourism=guest_house is still here, and when I answered no, it got tagged disused:shop=yes.

That is highly misleading (one might even argue it's flat out incorrect), as this issue notes, and the situation wouldn't be any better if it was tagged shop=vacant instead...

I'd much rather if just disused: prefix was prepended to main tag (i.e. amenity, shop, tourism, leisure?), e.g. in this case if it become disused:tourism=guest_house instead of tourism=guest_house . If is probably little more work, but I guess not much so, and for someone with command of Kotlin those maybe dozen lines of code would produce code which would IMHO be much better --- IOW not only more precise (which is always good thing IMHO), but more importantly it wouldn't blatantly lie and misrepresent the situation.

shops that have always been vacant (e.g. newly constructed shops), i.e. never had a tenant

But, if it has always been vacant, then StreetComplete will never change it's tagging anyway (to either shop=vacant or disused:shop=yes), so I don't think it applies to SC use case, right?

it describes the shop space being vacant, i.e. the now, rather than what it was before (disused:*)

Well, it abuses the tag (in many cases). Guest house which is no longer available for rent is hardly "vacant shop space" now.

[matkoniecz]

for disused:tourism=guest_house - this would be also wrong if space would be emptied to the point being generic empty commercial space, rather than being empty, currently unused, guest house

[westnordost]

Alright.

[natrius]

I just would like to add the discussion of https://community.openstreetmap.org/t/welche-fragen-stellt-streetcomplete-wem/114863/ about amenity=school turned to disused:shop=yes to be complete and because nobody else has done so.

Thanks for all your work!