-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when adding disused: SC deletes tags #4811
Comments
in which case shop is disused and not vacant?
not all see https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING.md#created-for-streetcomplete or more specifically https://github.com/mnalis/StreetComplete-taginfo-categorize lets take
you can still see object history, OSM stores what is currently in the world |
Can you clarify what you mean here? Are you using OSM data to map/check/visualise properties of no longer existing objects? |
To be honest, I do not think the |
When a shop closed "until further notice". Around the corner, I know such a shop. The shop is still there, but it hasn't been open for the last months and noone knows it will ever open again. To be honest, currently I simply do not re-tag this shop as being vacant (because it is not) and hold off on updating the opening hours (because I don't know how to tag "this is closed, always"). |
Indeed, I push old names of shop like others may push old names of streets. |
This explaination could be used for anykind of contribution. |
|
This information cannot be assumed to be mappable and verifiable. In fact, shops so notable to be remembered after their disappearance are really rare. It can be mapped with say
Note that keeping fully gone and no longer verifiable things like cuisine of past shops should be not mapped in OSM. Names of streets are in general remembered for long time, this is very unusual for shop names. If you want to map history - then OHM may be of interest, though I am not sure are they having notability requirements and is it OK to map say shops there. |
Saying such thing would mean that we may not push any ref:= because thare are a lot that are experts datas. I think when something is needed it's good to let it grow. My contributions are to let find the previous occupation. This information is very welcome for prospects and professionnals. |
OSM is for mapping currently existing features It is fine to map |
When a church becomes a cultural building, the building changes. It becomes a new amenity=theatre and was:amenity=place_of_worship ... |
We record in
This is not making using it mandatory, and using rather |
I do agree that sometimes old name is useful, especially if old sign still remains displayed, but in some other cases too (see my argument at #3045 (comment) for details) - whether as However, it seems the consensus was not to keep it, and I get it. If you care about history of the object, there is API history call that retrieves it, so that at least will work relatively simply with StreetComplete removal method. But note that as often as not, people will just delete old POI (and same or other people later create new POI), so all history and relationship will be lost, and you'd be forced to use much cruder and slower methods like Overpass Attic data to try to find what was there before if you really care about it.
That particular use case is however not related to this SC issue (StreetComplete deletion of the existing tags does not matter if the tag never existed in the first place - in that case, you can always add |
BTW, the tagging for that is |
It is not a consensus. If you look in taginfo more and more objects have an historical information when some significal changes have occured. |
in case where shop is gone and not operating, deleting shop entirely is a valid method of handling it mapping historical information (say, mapping and yes, there is way too high invalidly mapped historic objects - which in no way indicates any consensus as these objects are eliminated and deleted once revealed to be gone without any traces |
I meant StreetComplete consensus in that thread. Anyway, to cite was:* wiki documentation (without complaints on its talk page so far):
So, no,
I am looking at taginfo. Here is even taghistory for more perspective how insignificant I've linked above why I think OpenStreetMap is not historic database, but a database representing current state of the world. If you need the historic editing data, I think you should learn how to pull that data yourself. Anyway @JLZIMMERMANN, if you disagree with that statement, and think that all historic data should be always available in main OSM database (because it is useful for your use cases), you should argue for that direction at Tagging mailing list or OSM community forum to change to rules. There is not much point on complaining on this StreetComplete bug tracker - as it is not a bug in StreetComplete app, and there is nothing StreetComplete can really do (as intentionally going against documented tagging procedures and against community consensus in not really an option - for hopefully obvious reasons). |
There is a big problem : tags that are erased ! |
This tag removal was OK edit, when editing manually I would do the same edit. Removing info about no longer existing features is normal. For example removing cuisine info, opening hours info and name of no longer existing shop is a normal edit in OSM. |
Well, the user has chosen option named "It does not exist". Perhaps some translation is bad? To me, after choosing that something does not exist, it sounds perfectly clear and reasonable and expected that this will result in non-existent feature being deleted. In fact, I would be quite annoyed if I selected I want to delete something which does not exist anymore, and it did not get deleted.
I'm puzzled about what "lost quality" are we talking about, can you be more precise, or give better example than one at the top of this issue? To me it sounds perfectly reasonable that if restaurant does not exist anymore, that its cuisine does not exist anymore either (nor do its payment methods etc.). Surely, retaining obsolete data in current state database would not be an example of "letting quality remain"? Or am I misunderstanding? Other tags on that node which are likely to remain current (like But obsolete historical (non-current) data (like |
It would be better to change the previous tags with disused: prefix. |
Sometimes such objects do not have previous tags. In my area un south of France, students are mapping vacancy in several cities, they may add at the same time shop=vacan was: shop=* was:name=* to help municipalities to manage and get a dashboard. |
Iff there are traces of such shop, then adding this is fine. Note that StreetComplete will not remove tags for such objects, as long as it is in derelict state. Only if new shop open in its place then such tags may be removed as result of StreetComplete activity (not checked are they removed reliably). I will also unwatch this issue: if community consensus changes or there is something truly new - and not discussed already - then it would make sense to make a new issue. Please do not make a new issue if things were discussed here, even if you disagree with WONTFIXing this. |
Hi I bring a few points here as I don't understand the views against was:* keys, particularly about shops.
It's not recommended to do so: OSM version aren't reliable to distinguish an actual past usage and a mistake.
Discussion on this particular changeset shows that even unexpected information can show up and confuse mappers. We use many data sources, even outdated ones without having this in mind. Finding data that could trigger warnings and hints about possible mistake is better than nothing. |
Did you read was:* wiki page? Especially part that says "In most cases, in OSM, if you find a object in the database that don't exist on the ground, whether it existed or not, is an error or not, you should just delete it" ?
umm, "it is not recommended to do what"? Check OSM object history?
Well, yeah, no OSM tag (or other feature) is going to protect you against people making mistakes.
no?
I agree with you that iD can improve its checks. But this StreetComplete issue tracker is totally wrong place to request that. iD issue tracker is here for you to report that feature request.
Are we still talking about StreetComplete here? If so, what exact quests would you suggest that would check for such warnings, and that need on-site survey?
It is not unusual for people to make mistakes, yes. If the Mapillary imagery is older than last change date of the objects, then people should obviously should not be using data from it in order to destroy correct newer information with obsolete one. But it is on people using Mapillary (and other imagery) to check. No amount of history or tags will help if they do not bother to check. Perhaps it could be made more clear to Mapillary users in some documentation? Probably best to suggest it there.
They are not erased; they are moved to history (because that is historic i.e. "not current" information!). And that history one can easily access on osm.org site (click |
Well, was:* wiki page states that it can be used to disambiguate situations where data source is outdated and prevent mappers to restore past state of features (precisely what I'm arguing for upside). Whatever @JLZIMMERMANN is doing with was:* is not the business of this StreetComplete quest.
Get me well: I'm not expecting OSM versions to protect me from mistakes. My point is you can't distinguish mistakes from real ground changes.
You'll certainly get how the object was described in OSM, not how it was in real world. By the way, mentioning iD and Mapillary there was only for illustration.
We miss automated checks. The user has to think about looking in the history. Editors won't send him a warning because he is intended to restore past state of a given object, that's why we put was:* keys on. |
Absolutely -- that is truism. Nothing in OSM can be guaranteed to represent real state on the ground. Ever.
True, but nothing would tell you that if the French restaurant had ever existed in the real world. Even if you put Also, even if SC were to automatically rename old
Where do you miss them? In StreetComplete or elsewhere (in some other editors? in QA tools?) And if you miss automated checks in StreetComplete, how exactly do you envision that checks should work? Please describe an example and workflow what SC should check for, and what it should do it check indicates something is wrong? I.e. if you are suggesting a change in StreetComplete (as opposed to just expressing your general unhappiness about current state of software and OSM map data model generally), what actionable change exactly do you propose for SC, and what problems exactly do you think such solution will fix? |
I think StreetComplete shouldn't remove keys when it can't be always sure this removal will be relevant, particularly about was:* keys. Whatever the real usage can be, it should be discussed in every community concerned. |
I agree, that is why it is only removing no-longer relevant keys. In fact, a lot of effort (see https://github.com/mnalis/StreetComplete-taginfo-categorize) has been invested to make sure SC only removes keys which are no longer relevant when shop is gone, and that it retains all still-relevant tags. Feel free to open an issue there is you have actionable suggestion what keys are still existing even after to shop is removed and thus should stay (like
Or do you propose prefix chaining, to preserve even older values that were there before previous value, like
that would be re-implementing history database in completely wasteful, unreadable and horrible way. And if you're not proposing that and only want last thing it was before it become shoe store thing to be remembered, then two-steps-removed historical
It was discussed and documented at was:* wiki page:
If you want OSM to do/be something else, you should propose that to wider OSM community, not to StreetComplete.
Absolutely agree, that is why most people have unsubscribed from this issue by now. I've stayed a little longer (until now) to try to explain why it was rightfully rejected, as some people seem to not have understood and missed key points, and I wanted to help them understand.
As noted in wiki linked above and elsewhere, features that do not exist on the ground should be totally removed from the OSM main map. If you disagree with that OSM basic tenet that "OpenStreetMap represents physical features on the ground", and think it should include whole history of the world instead, I've linked above where and how you can propose it to be changed. I should warn you that you're likely to meet some resistance to that idea, though. Or, one should probably use OpenHistoricalMap instead if that is what they want. |
There is a simplest way use ";" to separate here you have an example |
No, that is simply wrong. But Also, this example is good only to show how
Anyway, whoever wanted to learn reasons why some tags are deleted and some not in SC, and why it is bad idea to abuse Those who don't/didn't -- well, I can't really help then, so better not to waste anyone's time any more. |
Note also that if wiki is wrong or should be less strict or recommend something else: then discuss it on OSM Wiki or on OSM forum (in general section, at https://community.openstreetmap.org/c/general/38 or its tagging subsection ) or tagging mailing list or maybe talk mailing list. (Note: I do not agree 100% with comment directly above, but that is not a place to discuss it) To repeat: If you want to map history - then OHM may be of interest, though I am not sure are they having notability requirements and is it OK to map say shops there. OpenStreetMap is not a place to map fully gone features. Edits done by StreetComplete linked in this thread match what human mapper would typically do and definitely could do and are OK to perform. |
For reference, behaviour was later changed in different way in #5548
If people are still curious, syntax for that is |
How to Reproduce
SC let edit POI about vacancy shop=vacant office=vacant disused:shop=yes
Unfortunatly in my professional experiment in localities it is better to use shop=vacant and office=vacant than disused:shop=yes.
This case disused:* means than the shop is not used but not implying vacancy.
StreetComplete application seems to erase all other tags. Unfortunatly I need these because I keep was:shop and was:name=* to help prospect to see what kind of retail would have been used before.
Example here : https://www.openstreetmap.org/node/302852529/history
Expected Behavior
If a shop becomes vacant, it would be welcome to change tags putting was:prefix before name and shop or office tags.
If there is already such prefix it could simply adding tags with the one already existing.
Versions affected
Android : 10QKQ1 StreetComplete 51
The text was updated successfully, but these errors were encountered: