This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add Licensing-Royalty integration and new LAP royalty policy #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Add Licensing-Royalty integration and new LAP royalty policy * add license integration hooks to royalty module * Add royalty policy LAP and ancestors vault * add natspec on onLinkToParents * add license data and external data inputs * adjust interfaces * adjust ancestorsVault contract and unit tests * adjust royalty policy LAP contract and unit tests * feat: License + Royalty integration #94 off rebase * test: fixing tests and flows * fix: royalty policy onLicenseMinting pulled out to correct position * test: Integration fix for SingleNftCollection test --------- Co-authored-by: Spablob <[email protected]> Co-authored-by: Raul <[email protected]>
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
…otocol#99) * Add Licensing-Royalty integration and new LAP royalty policy * add license integration hooks to royalty module * Add royalty policy LAP and ancestors vault * add natspec on onLinkToParents * add license data and external data inputs * adjust interfaces * adjust ancestorsVault contract and unit tests * adjust royalty policy LAP contract and unit tests * feat: License + Royalty integration storyprotocol#94 off rebase * test: fixing tests and flows * fix: royalty policy onLicenseMinting pulled out to correct position * test: Integration fix for SingleNftCollection test --------- Co-authored-by: Spablob <[email protected]> Co-authored-by: Raul <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds internal hooks for royalty and license integration
Adds the new LAP royalty policy and Ancestors vaults contracts and unit tests