Consider making Upgradeable CoreMetadataModule

[Ramarti]

The module itself doesn't have storage, but ipAccountStorage.setXXX will take the address of the caller as key.
If we want to change something from CoreMetadataModule by deploying another contract, all previous metadata would need to be migrated (either by the new module setting it all with a script, or each ipAccount migrating)

With a proxy, the address would be the same, so logic can be changed. This introduces the need for the user to trust us with the metadata, and weakens the promise of metadata freezing

[jdubpark]

This introduces the need for the user to trust us with the metadata

Code looks good, but this is something to consider since metadata can be made "immutable" (freeze). With the upgradeability, it's not completely immutable as code logic can change.

[Ramarti]

Very good point @jdubpark , updating the title.
Making IPAccounts migrate the metadata is perfectly fine too

[LeoHChen]

can you rebase the code? Also, @kingster-will can you review?

[jdubpark]

After some thoughts, I think we should make it upgradeable since the rest of the codebase is also upgradeable. We can renounce upgradeability for this module down the road (freezing from our side)

[kingster-will]

Please kindly also get review from @LeoHChen to confirm whether we need to make CoreMetadataModule upgradeable.