-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix handling of docsMode option in angular builder #20608
Conversation
@ssams would love a review on this. 🙏 |
@shilman I'll merge this if it goes green, since you approved the original PR |
looks good to me |
The CLI flag is called |
well, the CLI flag may be called like this, but the Angular builder option certainly is not, Angular wouldn't event allow to run the build when validating the storybook/code/frameworks/angular/src/builders/build-storybook/schema.json Lines 37 to 41 in 994a26d
I've been also using this patch locally applied to the stable v6 versions for months now, so it for sure works with these (e.g. also with currently latest https://github.com/storybookjs/storybook/releases/tag/v6.5.15). When I created the original PR it also fixed everything as intended for the upcoming v7, if it really doesn't anymore then something more in the Storybook builder internals must have changed. |
git remote add ssams [email protected]:ssams/storybook.git git fetch ssams angular-builder-fix-docs-mode git switch --track ssams/angular-builder-fix-docs-mode
Original PR: #18384
What I did
The
docsMode
option when using the angular builder had no effect when I tried to build a project using Storybook v6.5.6.The schema for the builder documents the option with the name
docsMode
(matching other documentation), however the implementation tries to forward a property with the namedocs
and ignores the other one.As the builder also uses the property name
docsMode
, no further mapping between the two names other than a simple renaming is done in this PR.Note that the relevant schema part seems to be last updated in #15194, however the implementation was not updated back then.