Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Use docsMode to set docs options #15194

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Angular: Use docsMode to set docs options #15194

merged 2 commits into from
Jun 10, 2021

Conversation

ThibaudAV
Copy link
Contributor

Issue:

What I did

use docsMode to set docs options

Setting the docs property to false seems to break things. probably used for other things.
docsMode seems to be the right option for the standalone run

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

setting the docs property to false seems to break things. probably used for other things.
docsMode seems to be the right option for the standalone run
@nx-cloud
Copy link

nx-cloud bot commented Jun 10, 2021

Nx Cloud Report

CI ran the following commands for commit b0c9617. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@ThibaudAV ThibaudAV requested a review from a team June 10, 2021 13:09
@shilman shilman changed the title Angular: use docsMode to set docs options Angular: Use docsMode to set docs options Jun 10, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants