Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix handling of docsMode option in angular builder #20608

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Angular: Fix handling of docsMode option in angular builder #20608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2731c70
fix(angular): properly forward docsMode option from angular builder
ssams Jun 1, 2022
7ec1bd0
Merge branch 'next' into pr/18384
shilman Jun 6, 2022
d5be794
fix(angular): properly forward docsMode option from angular builder
ssams Jun 1, 2022
649cbf8
Merge branch 'storybookjs-next' into angular-builder-fix-docs-mode
ssams Jul 26, 2022
f456526
Merge branch 'next' into angular-builder-fix-docs-mode
ndelangen Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions code/frameworks/angular/src/builders/build-storybook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ import { buildStandaloneErrorHandler } from '../utils/build-standalone-errors-ha
export type StorybookBuilderOptions = JsonObject & {
browserTarget?: string | null;
tsConfig?: string;
docsMode: boolean;
compodoc: boolean;
compodocArgs: string[];
styles?: ExtraEntryPoint[];
stylePreprocessorOptions?: StylePreprocessorOptions;
} & Pick<
// makes sure the option exists
CLIOptions,
'outputDir' | 'configDir' | 'loglevel' | 'quiet' | 'docs' | 'webpackStatsJson'
'outputDir' | 'configDir' | 'loglevel' | 'quiet' | 'webpackStatsJson'
>;

export type StorybookBuilderOutput = JsonObject & BuilderOutput & {};
Expand All @@ -59,7 +60,7 @@ function commandBuilder(
stylePreprocessorOptions,
styles,
configDir,
docs,
docsMode,
loglevel,
outputDir,
quiet,
Expand All @@ -69,7 +70,7 @@ function commandBuilder(
const standaloneOptions: StandaloneOptions = {
packageJson: readUpSync({ cwd: __dirname }).packageJson,
configDir,
docs,
docsMode,
loglevel,
outputDir,
quiet,
Expand Down
6 changes: 3 additions & 3 deletions code/frameworks/angular/src/builders/start-storybook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { buildStandaloneErrorHandler } from '../utils/build-standalone-errors-ha
export type StorybookBuilderOptions = JsonObject & {
browserTarget?: string | null;
tsConfig?: string;
docsMode: boolean;
compodoc: boolean;
compodocArgs: string[];
styles?: ExtraEntryPoint[];
Expand All @@ -42,7 +43,6 @@ export type StorybookBuilderOptions = JsonObject & {
| 'smokeTest'
| 'ci'
| 'quiet'
| 'docs'
>;

export type StorybookBuilderOutput = JsonObject & BuilderOutput & {};
Expand Down Expand Up @@ -70,7 +70,7 @@ function commandBuilder(
styles,
ci,
configDir,
docs,
docsMode,
host,
https,
port,
Expand All @@ -85,7 +85,7 @@ function commandBuilder(
packageJson: readUpSync({ cwd: __dirname }).packageJson,
ci,
configDir,
docs,
docsMode,
host,
https,
port,
Expand Down