Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBK-4] - Checkbox control does not update when using useArgs hook #19508

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Oct 17, 2022

Issue: #18639

What I did

Changing the value by checking checkboxes in the control correctly affects the component, and also the other way around. Selecting the options in the component updates the control.

How to test

  • cd code
  • yarn build
  • choose watch mode yes
  • production yes
  • choose @storybook/blocks

Open another terminal

  • cd code/examples/react-ts
  • cd yarn storybook

Video Demo

Video Demo

@gitstart gitstart marked this pull request as ready for review October 17, 2022 06:53
@gitstart gitstart changed the title [SBK-4-1] - Checkbox control does not update when using useArgs hook [SBK-4] - Checkbox control does not update when using useArgs hook Oct 17, 2022
@JReinhold
Copy link
Contributor

As part of my work in #19744 I confirmed this to be an issue, and this PR to fix it.

If you can resolve the merge conflict I'll happily merge this in.

@JReinhold
Copy link
Contributor

Thanks for this! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants